Address CodeRabbit review: filter events by period_end, fix ARG002 in stub

Author: sujalgoel

src/ghdcbot/engine/snapshots.py

@@ -284,7 +284,7 @@ def _collect_snapshot_data(
     notifications_data = []
     list_notifications = getattr(storage, "list_recent_notifications", None)
     if callable(list_notifications):
-        recent_notifications = list_notifications(limit=1000)  # Last 1000 notifications
+        recent_notifications = list_notifications(1000)  # Last 1000 notifications
         for notif in recent_notifications:
             notifications_data.append({
                 "dedupe_key": notif.get("dedupe_key"),
@@ -327,6 +327,7 @@ def _collect_snapshot_data(
                     "payload": event.payload,
                 }
                 for event in list_contributions(period_start)
+                if event.created_at <= period_end
             ]
             files["events.json"] = {
                 "schema_version": SCHEMA_VERSION,

tests/test_snapshots.py

@@ -501,7 +501,7 @@ def test_write_snapshots_raw_events_via_config() -> None:
 def test_raw_events_graceful_when_storage_missing_method() -> None:
     """events.json is omitted gracefully if storage lacks list_contributions."""
     class MinimalStorage:
-        def list_recent_notifications(self, limit: int = 1000) -> list[dict]:
+        def list_recent_notifications(self, _limit: int = 1000) -> list[dict]:
             return []
         def list_pending_issue_requests(self) -> list[dict]:
             return []