Skip to content

Commit d02330d

Browse files
AntonioFalcaoJrAntonioFalcaoJr
committed
Code smells
1 parent 904f187 commit d02330d

10 files changed

Lines changed: 46 additions & 71 deletions

File tree

‎src/Dotnet5.GraphQL3.CrossCutting/Dotnet5.GraphQL3.CrossCutting.csproj‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
<Project Sdk="Microsoft.NET.Sdk">
2-
32
<ItemGroup>
4-
<PackageReference Include="FluentValidation" Version="$(FluentValidation_Version)" />
5-
<PackageReference Include="GraphQL" Version="$(GraphQL_Version)" />
6-
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="$(Microsoft_DependencyInjection_Version)" />
7-
<PackageReference Include="Microsoft.Extensions.DependencyModel" Version="3.1.6" />
3+
<PackageReference Include="FluentValidation" Version="$(FluentValidation_Version)"/>
4+
<PackageReference Include="GraphQL" Version="$(GraphQL_Version)"/>
5+
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="$(Microsoft_DependencyInjection_Version)"/>
6+
<PackageReference Include="Microsoft.Extensions.DependencyModel" Version="3.1.6"/>
87
</ItemGroup>
9-
108
</Project>

‎src/Dotnet5.GraphQL3.Domain.Abstractions/Dotnet5.GraphQL3.Domain.Abstractions.csproj‎

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
11
<Project Sdk="Microsoft.NET.Sdk">
2-
32
<ItemGroup>
4-
<PackageReference Include="FluentValidation" Version="$(FluentValidation_Version)" />
5-
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="$(Microsoft_DependencyInjection_Version)" />
6-
<PackageReference Include="Scrutor" Version="$(Scrutor_Version)" />
3+
<PackageReference Include="FluentValidation" Version="$(FluentValidation_Version)"/>
4+
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="$(Microsoft_DependencyInjection_Version)"/>
5+
<PackageReference Include="Scrutor" Version="$(Scrutor_Version)"/>
76
</ItemGroup>
8-
97
<ItemGroup>
10-
<ProjectReference Include="..\Dotnet5.GraphQL3.CrossCutting\Dotnet5.GraphQL3.CrossCutting.csproj" />
8+
<ProjectReference Include="..\Dotnet5.GraphQL3.CrossCutting\Dotnet5.GraphQL3.CrossCutting.csproj"/>
119
</ItemGroup>
12-
1310
</Project>

‎src/Dotnet5.GraphQL3.Repositories.Abstractions/Dotnet5.GraphQL3.Repositories.Abstractions.csproj‎

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
11
<Project Sdk="Microsoft.NET.Sdk">
2-
32
<ItemGroup>
4-
<PackageReference Include="AutoMapper" Version="$(AutoMapper_Version)" />
5-
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="$(Microsoft_EntityFrameworkCore_Version)" />
6-
<PackageReference Include="Scrutor" Version="$(Scrutor_Version)" />
3+
<PackageReference Include="AutoMapper" Version="$(AutoMapper_Version)"/>
4+
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="$(Microsoft_EntityFrameworkCore_Version)"/>
5+
<PackageReference Include="Scrutor" Version="$(Scrutor_Version)"/>
76
</ItemGroup>
8-
97
<ItemGroup>
10-
<ProjectReference Include="..\Dotnet5.GraphQL3.Store.Domain\Dotnet5.GraphQL3.Store.Domain.csproj" />
8+
<ProjectReference Include="..\Dotnet5.GraphQL3.Store.Domain\Dotnet5.GraphQL3.Store.Domain.csproj"/>
119
</ItemGroup>
12-
1310
</Project>

‎src/Dotnet5.GraphQL3.Services.Abstractions/Dotnet5.GraphQL3.Services.Abstractions.csproj‎

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,14 @@
11
<Project Sdk="Microsoft.NET.Sdk">
2-
32
<ItemGroup>
4-
<PackageReference Include="AutoMapper" Version="$(AutoMapper_Version)" />
5-
<PackageReference Include="AutoMapper.Extensions.Microsoft.DependencyInjection" Version="$(AutoMapper_DependencyInjection_Version)" />
6-
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="$(Microsoft_EntityFrameworkCore_Version)" />
7-
<PackageReference Include="Scrutor" Version="$(Scrutor_Version)" />
3+
<PackageReference Include="AutoMapper" Version="$(AutoMapper_Version)"/>
4+
<PackageReference Include="AutoMapper.Extensions.Microsoft.DependencyInjection" Version="$(AutoMapper_DependencyInjection_Version)"/>
5+
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="$(Microsoft_EntityFrameworkCore_Version)"/>
6+
<PackageReference Include="Scrutor" Version="$(Scrutor_Version)"/>
87
</ItemGroup>
9-
108
<ItemGroup>
11-
<ProjectReference Include="..\Dotnet5.GraphQL3.CrossCutting\Dotnet5.GraphQL3.CrossCutting.csproj" />
12-
<ProjectReference Include="..\Dotnet5.GraphQL3.Repositories.Abstractions\Dotnet5.GraphQL3.Repositories.Abstractions.csproj" />
13-
<ProjectReference Include="..\Dotnet5.GraphQL3.Store.Domain\Dotnet5.GraphQL3.Store.Domain.csproj" />
9+
<ProjectReference Include="..\Dotnet5.GraphQL3.CrossCutting\Dotnet5.GraphQL3.CrossCutting.csproj"/>
10+
<ProjectReference Include="..\Dotnet5.GraphQL3.Repositories.Abstractions\Dotnet5.GraphQL3.Repositories.Abstractions.csproj"/>
11+
<ProjectReference Include="..\Dotnet5.GraphQL3.Store.Domain\Dotnet5.GraphQL3.Store.Domain.csproj"/>
1412
</ItemGroup>
1513

1614
<ItemGroup>

‎src/Dotnet5.GraphQL3.Store.Domain/Dotnet5.GraphQL3.Store.Domain.csproj‎

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,21 @@
11
<Project Sdk="Microsoft.NET.Sdk">
2-
32
<ItemGroup>
4-
<PackageReference Include="FluentValidation" Version="$(FluentValidation_Version)" />
3+
<PackageReference Include="FluentValidation" Version="$(FluentValidation_Version)"/>
4+
</ItemGroup>
5+
<ItemGroup>
6+
<ProjectReference Include="..\Dotnet5.GraphQL3.Domain.Abstractions\Dotnet5.GraphQL3.Domain.Abstractions.csproj"/>
57
</ItemGroup>
6-
78
<ItemGroup>
89
<EmbeddedResource Update="Resource.resx">
910
<Generator>ResXFileCodeGenerator</Generator>
1011
<LastGenOutput>Resource.Designer.cs</LastGenOutput>
1112
</EmbeddedResource>
1213
</ItemGroup>
13-
1414
<ItemGroup>
1515
<Compile Update="Resource.Designer.cs">
1616
<DesignTime>True</DesignTime>
1717
<AutoGen>True</AutoGen>
1818
<DependentUpon>DomainResource.resx</DependentUpon>
1919
</Compile>
2020
</ItemGroup>
21-
22-
<ItemGroup>
23-
<ProjectReference Include="..\Dotnet5.GraphQL3.Domain.Abstractions\Dotnet5.GraphQL3.Domain.Abstractions.csproj" />
24-
</ItemGroup>
25-
2621
</Project>

‎src/Dotnet5.GraphQL3.Store.Repositories/Contexts/StoreDbContext.cs‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ namespace Dotnet5.GraphQL3.Store.Repositories.Contexts
77
{
88
public class StoreDbContext : DbContext
99
{
10+
private const string SqlLatin1GeneralCp1CsAs = "SQL_Latin1_General_CP1_CS_AS";
11+
1012
public StoreDbContext(DbContextOptions options)
1113
: base(options) { }
1214

@@ -16,7 +18,7 @@ public StoreDbContext(DbContextOptions options)
1618

1719
protected override void OnModelCreating(ModelBuilder modelBuilder)
1820
{
19-
modelBuilder.UseCollation("SQL_Latin1_General_CP1_CS_AS");
21+
modelBuilder.UseCollation(SqlLatin1GeneralCp1CsAs);
2022
modelBuilder.ApplyConfigurationsFromAssembly(typeof(StoreDbContext).Assembly);
2123
modelBuilder.Seed();
2224
base.OnModelCreating(modelBuilder);

‎src/Dotnet5.GraphQL3.Store.Repositories/Dotnet5.GraphQL3.Store.Repositories.csproj‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
11
<Project Sdk="Microsoft.NET.Sdk">
2-
32
<ItemGroup>
4-
<PackageReference Include="Bogus" Version="33.0.2" />
5-
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="$(Microsoft_EntityFrameworkCore_Version)" />
6-
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="$(Microsoft_EntityFrameworkCore_Version)" />
7-
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="$(Microsoft_EntityFrameworkCore_Version)" />
3+
<PackageReference Include="Bogus" Version="33.0.2"/>
4+
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="$(Microsoft_EntityFrameworkCore_Version)"/>
5+
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="$(Microsoft_EntityFrameworkCore_Version)"/>
6+
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="$(Microsoft_EntityFrameworkCore_Version)"/>
87
</ItemGroup>
9-
108
<ItemGroup>
11-
<ProjectReference Include="..\Dotnet5.GraphQL3.Repositories.Abstractions\Dotnet5.GraphQL3.Repositories.Abstractions.csproj" />
9+
<ProjectReference Include="..\Dotnet5.GraphQL3.Repositories.Abstractions\Dotnet5.GraphQL3.Repositories.Abstractions.csproj"/>
1210
</ItemGroup>
13-
1411
</Project>

‎src/Dotnet5.GraphQL3.Store.Services/Dotnet5.GraphQL3.Store.Services.csproj‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk">
2-
32
<ItemGroup>
4-
<ProjectReference Include="..\Dotnet5.GraphQL3.Services.Abstractions\Dotnet5.GraphQL3.Services.Abstractions.csproj" />
5-
<ProjectReference Include="..\Dotnet5.GraphQL3.Store.Repositories\Dotnet5.GraphQL3.Store.Repositories.csproj" />
3+
<ProjectReference Include="..\Dotnet5.GraphQL3.Services.Abstractions\Dotnet5.GraphQL3.Services.Abstractions.csproj"/>
4+
<ProjectReference Include="..\Dotnet5.GraphQL3.Store.Repositories\Dotnet5.GraphQL3.Store.Repositories.csproj"/>
65
</ItemGroup>
7-
86
</Project>

‎src/Dotnet5.GraphQL3.Store.WebAPI/Dotnet5.GraphQL3.Store.WebAPI.csproj‎

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,18 @@
11
<Project Sdk="Microsoft.NET.Sdk.Web">
2-
32
<PropertyGroup>
43
<UserSecretsId>50d27449-38cf-4054-be72-138f16c2f4e3</UserSecretsId>
54
</PropertyGroup>
6-
75
<ItemGroup>
8-
<PackageReference Include="AspNetCore.HealthChecks.SqlServer" Version="5.0.2" />
9-
<PackageReference Include="GraphQL" Version="$(GraphQL_Version)" />
10-
<PackageReference Include="GraphQL.Server.Transports.AspNetCore" Version="$(GraphQL_Server_Version)" />
11-
<PackageReference Include="GraphQL.Server.Transports.AspNetCore.SystemTextJson" Version="$(GraphQL_Server_Version)" />
12-
<PackageReference Include="GraphQL.Server.Transports.WebSockets" Version="$(GraphQL_Server_Version)" />
13-
<PackageReference Include="GraphQL.Server.Ui.Playground" Version="$(GraphQL_Server_Version)" />
6+
<PackageReference Include="AspNetCore.HealthChecks.SqlServer" Version="5.0.2"/>
7+
<PackageReference Include="GraphQL" Version="$(GraphQL_Version)"/>
8+
<PackageReference Include="GraphQL.Server.Transports.AspNetCore" Version="$(GraphQL_Server_Version)"/>
9+
<PackageReference Include="GraphQL.Server.Transports.AspNetCore.SystemTextJson" Version="$(GraphQL_Server_Version)"/>
10+
<PackageReference Include="GraphQL.Server.Transports.WebSockets" Version="$(GraphQL_Server_Version)"/>
11+
<PackageReference Include="GraphQL.Server.Ui.Playground" Version="$(GraphQL_Server_Version)"/>
1412
</ItemGroup>
15-
1613
<ItemGroup>
17-
<ProjectReference Include="..\Dotnet5.GraphQL3.CrossCutting\Dotnet5.GraphQL3.CrossCutting.csproj" />
18-
<ProjectReference Include="..\Dotnet5.GraphQL3.Store.Repositories\Dotnet5.GraphQL3.Store.Repositories.csproj" />
19-
<ProjectReference Include="..\Dotnet5.GraphQL3.Store.Services\Dotnet5.GraphQL3.Store.Services.csproj" />
14+
<ProjectReference Include="..\Dotnet5.GraphQL3.CrossCutting\Dotnet5.GraphQL3.CrossCutting.csproj"/>
15+
<ProjectReference Include="..\Dotnet5.GraphQL3.Store.Repositories\Dotnet5.GraphQL3.Store.Repositories.csproj"/>
16+
<ProjectReference Include="..\Dotnet5.GraphQL3.Store.Services\Dotnet5.GraphQL3.Store.Services.csproj"/>
2017
</ItemGroup>
21-
2218
</Project>

‎src/Dotnet5.GraphQL3.Store.WebMVC/Dotnet5.GraphQL3.Store.WebMVC.csproj‎

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
11
<Project Sdk="Microsoft.NET.Sdk.Web">
2-
32
<PropertyGroup>
43
<UserSecretsId>8f952f5c-df2d-4433-87fb-15f534a39270</UserSecretsId>
54
</PropertyGroup>
6-
75
<ItemGroup>
8-
<PackageReference Include="AspNetCore.HealthChecks.Uris" Version="5.0.1" />
9-
<PackageReference Include="GraphQL.Client" Version="$(GraphQL_Client_Version)" />
10-
<PackageReference Include="GraphQL.Client.Extensions" Version="3.0.1" />
11-
<PackageReference Include="GraphQL.Client.Serializer.SystemTextJson" Version="$(GraphQL_Client_Version)" />
6+
<PackageReference Include="AspNetCore.HealthChecks.Uris" Version="5.0.1"/>
7+
<PackageReference Include="GraphQL.Client" Version="$(GraphQL_Client_Version)"/>
8+
<PackageReference Include="GraphQL.Client.Extensions" Version="3.0.1"/>
9+
<PackageReference Include="GraphQL.Client.Serializer.SystemTextJson" Version="$(GraphQL_Client_Version)"/>
1210
</ItemGroup>
13-
1411
</Project>

0 commit comments

Comments
 (0)