|
5 | 5 | */ |
6 | 6 |
|
7 | 7 | import assert from 'node:assert'; |
8 | | -import {describe, it, mock} from 'node:test'; |
| 8 | +import {describe, it, afterEach, beforeEach} from 'node:test'; |
| 9 | + |
| 10 | +import sinon from 'sinon'; |
9 | 11 |
|
10 | 12 | import {ClearcutLogger} from '../../src/telemetry/clearcut-logger.js'; |
11 | 13 | import {ClearcutSender} from '../../src/telemetry/clearcut-sender.js'; |
| 14 | +import type {Persistence} from '../../src/telemetry/persistence.js'; |
| 15 | +import {FilePersistence} from '../../src/telemetry/persistence.js'; |
12 | 16 |
|
13 | 17 | describe('ClearcutLogger', () => { |
14 | | - it('should log tool invocation via sender', async () => { |
15 | | - const sender = new ClearcutSender(); |
16 | | - const sendSpy = mock.method(sender, 'send'); |
17 | | - const loggerInstance = new ClearcutLogger(sender); |
18 | | - |
19 | | - await loggerInstance.logToolInvocation({ |
20 | | - toolName: 'test-tool', |
21 | | - success: true, |
22 | | - latencyMs: 100, |
| 18 | + let mockPersistence: sinon.SinonStubbedInstance<Persistence>; |
| 19 | + let mockSender: sinon.SinonStubbedInstance<ClearcutSender>; |
| 20 | + |
| 21 | + beforeEach(() => { |
| 22 | + mockPersistence = sinon.createStubInstance(FilePersistence, { |
| 23 | + loadState: Promise.resolve({ |
| 24 | + lastActive: '', |
| 25 | + }), |
| 26 | + }); |
| 27 | + mockSender = sinon.createStubInstance(ClearcutSender); |
| 28 | + mockSender.send.resolves(); |
| 29 | + }); |
| 30 | + |
| 31 | + afterEach(() => { |
| 32 | + sinon.restore(); |
| 33 | + }); |
| 34 | + |
| 35 | + describe('logToolInvocation', () => { |
| 36 | + it('sends correct payload', async () => { |
| 37 | + const logger = new ClearcutLogger({ |
| 38 | + persistence: mockPersistence, |
| 39 | + sender: mockSender, |
| 40 | + }); |
| 41 | + await logger.logToolInvocation({ |
| 42 | + toolName: 'test_tool', |
| 43 | + success: true, |
| 44 | + latencyMs: 123, |
| 45 | + }); |
| 46 | + |
| 47 | + assert(mockSender.send.calledOnce); |
| 48 | + const extension = mockSender.send.firstCall.args[0]; |
| 49 | + assert.strictEqual(extension.tool_invocation?.tool_name, 'test_tool'); |
| 50 | + assert.strictEqual(extension.tool_invocation?.success, true); |
| 51 | + assert.strictEqual(extension.tool_invocation?.latency_ms, 123); |
23 | 52 | }); |
| 53 | + }); |
| 54 | + |
| 55 | + describe('logServerStart', () => { |
| 56 | + it('logs flag usage', async () => { |
| 57 | + const logger = new ClearcutLogger({ |
| 58 | + persistence: mockPersistence, |
| 59 | + sender: mockSender, |
| 60 | + }); |
| 61 | + |
| 62 | + await logger.logServerStart({headless: true}); |
24 | 63 |
|
25 | | - assert.strictEqual(sendSpy.mock.callCount(), 1); |
26 | | - const event = sendSpy.mock.calls[0].arguments[0]; |
27 | | - assert.deepStrictEqual(event.tool_invocation, { |
28 | | - tool_name: 'test-tool', |
29 | | - success: true, |
30 | | - latency_ms: 100, |
| 64 | + // Should have logged server start |
| 65 | + const calls = mockSender.send.getCalls(); |
| 66 | + const serverStartCall = calls.find(call => { |
| 67 | + return !!call.args[0].server_start; |
| 68 | + }); |
| 69 | + |
| 70 | + assert(serverStartCall); |
| 71 | + assert.strictEqual( |
| 72 | + serverStartCall.args[0].server_start?.flag_usage?.headless, |
| 73 | + true, |
| 74 | + ); |
31 | 75 | }); |
32 | 76 | }); |
33 | 77 |
|
34 | | - it('should log server start via sender', async () => { |
35 | | - const sender = new ClearcutSender(); |
36 | | - const sendSpy = mock.method(sender, 'send'); |
37 | | - const loggerInstance = new ClearcutLogger(sender); |
| 78 | + describe('logDailyActiveIfNeeded', () => { |
| 79 | + it('logs daily active if needed (lastActive > 24h ago)', async () => { |
| 80 | + const yesterday = new Date(); |
| 81 | + yesterday.setDate(yesterday.getDate() - 1); |
| 82 | + |
| 83 | + mockPersistence.loadState.resolves({ |
| 84 | + lastActive: yesterday.toISOString(), |
| 85 | + }); |
| 86 | + |
| 87 | + const logger = new ClearcutLogger({ |
| 88 | + persistence: mockPersistence, |
| 89 | + sender: mockSender, |
| 90 | + }); |
| 91 | + |
| 92 | + await logger.logDailyActiveIfNeeded(); |
| 93 | + |
| 94 | + const calls = mockSender.send.getCalls(); |
| 95 | + const dailyActiveCall = calls.find(call => { |
| 96 | + return !!call.args[0].daily_active; |
| 97 | + }); |
| 98 | + |
| 99 | + assert(dailyActiveCall, 'Should have logged daily active'); |
| 100 | + assert(mockPersistence.saveState.called); |
| 101 | + }); |
| 102 | + |
| 103 | + it('does not log daily active if not needed (today)', async () => { |
| 104 | + mockPersistence.loadState.resolves({ |
| 105 | + lastActive: new Date().toISOString(), |
| 106 | + }); |
| 107 | + |
| 108 | + const logger = new ClearcutLogger({ |
| 109 | + persistence: mockPersistence, |
| 110 | + sender: mockSender, |
| 111 | + }); |
| 112 | + |
| 113 | + await logger.logDailyActiveIfNeeded(); |
| 114 | + |
| 115 | + const calls = mockSender.send.getCalls(); |
| 116 | + const dailyActiveCall = calls.find(call => { |
| 117 | + return !!call.args[0].daily_active; |
| 118 | + }); |
| 119 | + |
| 120 | + assert(!dailyActiveCall, 'Should NOT have logged daily active'); |
| 121 | + assert(mockPersistence.saveState.notCalled); |
| 122 | + }); |
| 123 | + |
| 124 | + it('logs daily active with -1 if lastActive is missing', async () => { |
| 125 | + mockPersistence.loadState.resolves({ |
| 126 | + lastActive: '', |
| 127 | + }); |
| 128 | + |
| 129 | + const logger = new ClearcutLogger({ |
| 130 | + persistence: mockPersistence, |
| 131 | + sender: mockSender, |
| 132 | + }); |
| 133 | + |
| 134 | + await logger.logDailyActiveIfNeeded(); |
38 | 135 |
|
39 | | - await loggerInstance.logServerStart({headless: true}); |
| 136 | + const calls = mockSender.send.getCalls(); |
| 137 | + const dailyActiveCall = calls.find(call => { |
| 138 | + return !!call.args[0].daily_active; |
| 139 | + }); |
40 | 140 |
|
41 | | - assert.strictEqual(sendSpy.mock.callCount(), 1); |
42 | | - const event = sendSpy.mock.calls[0].arguments[0]; |
43 | | - assert.deepStrictEqual(event.server_start, { |
44 | | - flag_usage: {headless: true}, |
| 141 | + assert(dailyActiveCall, 'Should have logged daily active'); |
| 142 | + assert.strictEqual( |
| 143 | + dailyActiveCall.args[0].daily_active?.days_since_last_active, |
| 144 | + -1, |
| 145 | + ); |
| 146 | + assert(mockPersistence.saveState.called); |
45 | 147 | }); |
46 | 148 | }); |
47 | 149 | }); |
0 commit comments