Skip to content

Commit a5134c6

Browse files
authored
chore: refactor names for console formatters (#803)
1 parent feee900 commit a5134c6

1 file changed

Lines changed: 14 additions & 12 deletions

File tree

src/McpResponse.ts

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ export class McpResponse implements Response {
229229
detailedNetworkRequest = formatter;
230230
}
231231

232-
let consoleData: ConsoleFormatter | IssueFormatter | undefined;
232+
let detailedConsoleMessage: ConsoleFormatter | IssueFormatter | undefined;
233233

234234
if (this.#attachedConsoleMessageId) {
235235
const message = context.getConsoleMessageById(
@@ -239,7 +239,7 @@ export class McpResponse implements Response {
239239
if ('args' in message) {
240240
const consoleMessage = message as ConsoleMessage;
241241
const devTools = context.getDevToolsUniverse();
242-
consoleData = await ConsoleFormatter.from(consoleMessage, {
242+
detailedConsoleMessage = await ConsoleFormatter.from(consoleMessage, {
243243
id: consoleMessageStableId,
244244
fetchDetailedData: true,
245245
devTools: devTools ?? undefined,
@@ -255,15 +255,15 @@ export class McpResponse implements Response {
255255
"Can't provide detals for the msgid " + consoleMessageStableId,
256256
);
257257
}
258-
consoleData = formatter;
258+
detailedConsoleMessage = formatter;
259259
} else {
260-
consoleData = await ConsoleFormatter.from(message as Error, {
260+
detailedConsoleMessage = await ConsoleFormatter.from(message as Error, {
261261
id: consoleMessageStableId,
262262
});
263263
}
264264
}
265265

266-
let consoleListData: Array<ConsoleFormatter | IssueFormatter> | undefined;
266+
let consoleMessages: Array<ConsoleFormatter | IssueFormatter> | undefined;
267267
if (this.#consoleDataOptions?.include) {
268268
let messages = context.getConsoleData(
269269
this.#consoleDataOptions.includePreservedMessages,
@@ -282,7 +282,7 @@ export class McpResponse implements Response {
282282
});
283283
}
284284

285-
consoleListData = (
285+
consoleMessages = (
286286
await Promise.all(
287287
messages.map(
288288
async (item): Promise<ConsoleFormatter | IssueFormatter | null> => {
@@ -354,8 +354,8 @@ export class McpResponse implements Response {
354354
}
355355

356356
return this.format(toolName, context, {
357-
consoleData,
358-
consoleListData,
357+
detailedConsoleMessage,
358+
consoleMessages,
359359
snapshot,
360360
detailedNetworkRequest,
361361
networkRequests,
@@ -366,8 +366,8 @@ export class McpResponse implements Response {
366366
toolName: string,
367367
context: McpContext,
368368
data: {
369-
consoleData: ConsoleFormatter | IssueFormatter | undefined;
370-
consoleListData: Array<ConsoleFormatter | IssueFormatter> | undefined;
369+
detailedConsoleMessage: ConsoleFormatter | IssueFormatter | undefined;
370+
consoleMessages: Array<ConsoleFormatter | IssueFormatter> | undefined;
371371
snapshot: SnapshotFormatter | string | undefined;
372372
detailedNetworkRequest?: NetworkFormatter;
373373
networkRequests?: NetworkFormatter[];
@@ -454,7 +454,9 @@ Call ${handleDialog.name} to handle it before continuing.`);
454454
structuredContent.networkRequest =
455455
data.detailedNetworkRequest.toJSONDetailed();
456456
}
457-
response.push(...this.#formatConsoleData(context, data.consoleData));
457+
response.push(
458+
...this.#formatConsoleData(context, data.detailedConsoleMessage),
459+
);
458460

459461
if (this.#networkRequestsOptions?.include) {
460462
let requests = context.getNetworkRequests(
@@ -492,7 +494,7 @@ Call ${handleDialog.name} to handle it before continuing.`);
492494
}
493495

494496
if (this.#consoleDataOptions?.include) {
495-
const messages = data.consoleListData ?? [];
497+
const messages = data.consoleMessages ?? [];
496498

497499
response.push('## Console messages');
498500
if (messages.length) {

0 commit comments

Comments
 (0)