test: update test to include off by defaults tools

Author: nroscino

skills/troubleshooting/SKILL.md

@@ -52,7 +52,7 @@ All tools in `chrome-devtools-mcp` are annotated with `readOnlyHint: true` (for
 If the tools related to extensions (like `install_extension`) are not available, or if the extensions you load are not functioning:
 
 1. **Check for the `--categoryExtensions` flag**: Ensure this flag is passed in the MCP server configuration to enable the extension category tools.
-2. **Make sure the MCP server in configured to launch Chrome instead of connecting to an instance. Chrome before 149 is not able to load extensions when connecting to existing instance (`--auto-connect`, `--browserUrl`).
+2. \*\*Make sure the MCP server in configured to launch Chrome instead of connecting to an instance. Chrome before 149 is not able to load extensions when connecting to existing instance (`--auto-connect`, `--browserUrl`).
 
 #### Other Common Errors
 

src/index.ts

@@ -136,7 +136,7 @@ export async function createMcpServer(
     }
     if (
       tool.annotations.category === ToolCategory.EXTENSIONS &&
-      !serverArgs.categoryExtensions
+      serverArgs.categoryExtensions === false
     ) {
       return;
     }

tests/index.test.ts

@@ -12,7 +12,11 @@ import {Client} from '@modelcontextprotocol/sdk/client/index.js';
 import {StdioClientTransport} from '@modelcontextprotocol/sdk/client/stdio.js';
 import {executablePath} from 'puppeteer';
 
-import type {ToolDefinition} from '../src/tools/ToolDefinition';
+import {
+  OFF_BY_DEFAULT_CATEGORIES,
+  ToolCategory,
+} from '../src/tools/categories.js';
+import type {ToolDefinition} from '../src/tools/ToolDefinition.js';
 
 describe('e2e', () => {
   async function withClient(
@@ -71,6 +75,56 @@ describe('e2e', () => {
     });
   });
 
+  it('has all tools with off by default categories', async () => {
+    await withClient(
+      async client => {
+        const {tools} = await client.listTools();
+        const exposedNames = tools.map(t => t.name).sort();
+        const files = fs.readdirSync('build/src/tools');
+        const definedNames = [];
+        for (const file of files) {
+          if (
+            file === 'ToolDefinition.js' ||
+            file === 'tools.js' ||
+            file === 'slim'
+          ) {
+            continue;
+          }
+          const fileTools = await import(`../src/tools/${file}`);
+          for (const maybeTool of Object.values<unknown>(fileTools)) {
+            if (typeof maybeTool === 'function') {
+              const tool = (maybeTool as (val: boolean) => ToolDefinition)(
+                false,
+              );
+              if (tool && typeof tool === 'object' && 'name' in tool) {
+                if (tool.annotations?.conditions) {
+                  continue;
+                }
+                definedNames.push(tool.name);
+              }
+              continue;
+            }
+            if (
+              typeof maybeTool === 'object' &&
+              maybeTool !== null &&
+              'name' in maybeTool
+            ) {
+              const tool = maybeTool as ToolDefinition;
+              if (tool.annotations?.conditions) {
+                continue;
+              }
+              definedNames.push(tool.name);
+            }
+          }
+        }
+
+        definedNames.sort();
+        assert.deepStrictEqual(exposedNames, definedNames);
+      },
+      OFF_BY_DEFAULT_CATEGORIES.map(category => `--category-${category}`),
+    );
+  });
+
   it('has all tools', async () => {
     await withClient(async client => {
       const {tools} = await client.listTools();
@@ -93,6 +147,12 @@ describe('e2e', () => {
               if (tool.annotations?.conditions) {
                 continue;
               }
+              if (
+                tool.annotations?.category &&
+                tool.annotations?.category === ToolCategory.EXTENSIONS
+              ) {
+                continue;
+              }
               definedNames.push(tool.name);
             }
             continue;
@@ -106,10 +166,17 @@ describe('e2e', () => {
             if (tool.annotations?.conditions) {
               continue;
             }
+            if (
+              tool.annotations?.category &&
+              tool.annotations?.category === ToolCategory.EXTENSIONS
+            ) {
+              continue;
+            }
             definedNames.push(tool.name);
           }
         }
       }
+
       definedNames.sort();
       assert.deepStrictEqual(exposedNames, definedNames);
     });