chore: code review

Author: OrKoN

README.md

@@ -495,6 +495,10 @@ The Chrome DevTools MCP server supports the following configuration option:
   If enabled, ignores errors relative to self-signed and expired certificates. Use with caution.
   - **Type:** boolean
 
+- **`--experimentalScreencast`/ `--experimental-screencast`**
+  Exposes experimental screencast tools (requires ffmpeg). Install ffmpeg https://www.ffmpeg.org/download.html and ensure it is available in the MCP server PATH.
+  - **Type:** boolean
+
 - **`--chromeArg`/ `--chrome-arg`**
   Additional arguments for Chrome. Only applies when Chrome is launched by chrome-devtools-mcp.
   - **Type:** array

src/cli.ts

@@ -175,8 +175,8 @@ export const cliOptions = {
   },
   experimentalScreencast: {
     type: 'boolean',
-    describe: 'Whether to enable screencast tools',
-    hidden: true,
+    describe:
+      'Exposes experimental screencast tools (requires ffmpeg). Install ffmpeg https://www.ffmpeg.org/download.html and ensure it is available in the MCP server PATH.',
   },
   chromeArg: {
     type: 'array',

src/tools/screencast.ts

@@ -12,7 +12,6 @@ import {zod} from '../third_party/index.js';
 import type {ScreenRecorder} from '../third_party/index.js';
 
 import {ToolCategory} from './categories.js';
-import type {Context, Response} from './ToolDefinition.js';
 import {defineTool} from './ToolDefinition.js';
 
 async function generateTempFilePath(): Promise<string> {
@@ -23,7 +22,7 @@ async function generateTempFilePath(): Promise<string> {
 export const startScreencast = defineTool({
   name: 'screencast_start',
   description:
-    'Starts recording a screencast (video) of the selected page in mp4 format. Requires ffmpeg to be installed on the system.',
+    'Starts recording a screencast (video) of the selected page in mp4 format.',
   annotations: {
     category: ToolCategory.DEBUGGING,
     readOnlyHint: false,
@@ -70,7 +69,7 @@ export const startScreencast = defineTool({
     context.setScreenRecorder({recorder, filePath: resolvedPath});
 
     response.appendResponseLine(
-      `Screencast recording started. The recording will be saved to ${resolvedPath}. Use screencast_stop to stop recording.`,
+      `Screencast recording started. The recording will be saved to ${resolvedPath}. Use ${stopScreencast.name} to stop recording.`,
     );
   },
 });
@@ -85,24 +84,17 @@ export const stopScreencast = defineTool({
   },
   schema: {},
   handler: async (_request, response, context) => {
-    await stopScreencastAndAppendOutput(response, context);
+    const data = context.getScreenRecorder();
+    if (!data) {
+      return;
+    }
+    try {
+      await data.recorder.stop();
+      response.appendResponseLine(
+        `The screencast recording has been stopped and saved to ${data.filePath}.`,
+      );
+    } finally {
+      context.setScreenRecorder(null);
+    }
   },
 });
-
-async function stopScreencastAndAppendOutput(
-  response: Response,
-  context: Context,
-): Promise<void> {
-  const data = context.getScreenRecorder();
-  if (!data) {
-    return;
-  }
-  try {
-    await data.recorder.stop();
-    response.appendResponseLine(
-      `The screencast recording has been stopped and saved to ${data.filePath}.`,
-    );
-  } finally {
-    context.setScreenRecorder(null);
-  }
-}

tests/tools/screencast.test.ts

@@ -60,11 +60,7 @@ describe('screencast', () => {
           .stub(selectedPage, 'screencast')
           .resolves(mockRecorder as never);
 
-        await startScreencast.handler(
-          {params: {}},
-          response,
-          context,
-        );
+        await startScreencast.handler({params: {}}, response, context);
 
         sinon.assert.calledOnce(screencastStub);
         const callArgs = screencastStub.firstCall.args[0];
@@ -74,35 +70,6 @@ describe('screencast', () => {
       });
     });
 
-    it('passes format and quality options', async () => {
-      await withMcpContext(async (response, context) => {
-        const mockRecorder = createMockRecorder();
-        const selectedPage = context.getSelectedPage();
-        const screencastStub = sinon
-          .stub(selectedPage, 'screencast')
-          .resolves(mockRecorder as never);
-
-        await startScreencast.handler(
-          {
-            params: {
-              path: '/tmp/test.mp4',
-            },
-          },
-          response,
-          context,
-        );
-
-        sinon.assert.calledOnce(screencastStub);
-        const callArgs = screencastStub.firstCall.args[0];
-        assert.ok(callArgs);
-        assert.strictEqual(callArgs.format, 'mp4');
-        assert.strictEqual(callArgs.quality, 20);
-        assert.strictEqual(callArgs.fps, 24);
-        assert.strictEqual(callArgs.scale, 0.5);
-        assert.strictEqual(callArgs.speed, 2);
-      });
-    });
-
     it('errors if a recording is already active', async () => {
       await withMcpContext(async (response, context) => {
         const mockRecorder = createMockRecorder();
@@ -114,11 +81,7 @@ describe('screencast', () => {
         const selectedPage = context.getSelectedPage();
         const screencastStub = sinon.stub(selectedPage, 'screencast');
 
-        await startScreencast.handler(
-          {params: {}},
-          response,
-          context,
-        );
+        await startScreencast.handler({params: {}}, response, context);
 
         sinon.assert.notCalled(screencastStub);
         assert.ok(