Skip to content

Commit 5d8c8b3

Browse files
committed
Improve logging and comments
1 parent 8198574 commit 5d8c8b3

3 files changed

Lines changed: 28 additions & 28 deletions

File tree

server/api/services/embedding_services.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import logging
33
from statistics import median
44

5-
# Django filter() only does ADD logic
5+
# Use Q objects to express OR conditions in Django queries
66
from django.db.models import Q
77
from pgvector.django import L2Distance
88

@@ -146,8 +146,8 @@ def log_usage(
146146
median_distance=None,
147147
min_distance=None,
148148
)
149-
except Exception as e:
150-
logger.error(f"Failed to create semantic search usage database record: {e}")
149+
except Exception:
150+
logger.exception("Failed to create semantic search usage database record")
151151

152152

153153
def get_closest_embeddings(

server/api/services/test_embedding_services.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
# ---------------------------------------------------------------------------
2727

2828
# Only forwarded to L2Distance
29-
EMBEDDING_VECTOR = [0.1, 0.2, 0.3]
29+
EMBEDDING_VECTOR = [0.1, 0.2, 0.3]
3030

3131
# Test authenticated/unauthenticated user access control
3232

server/balancer_backend/settings.py

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -254,27 +254,27 @@
254254

255255
# Logging configuration
256256

257-
# LOGGING = {
258-
# "version": 1,
259-
# "disable_existing_loggers": False,
260-
# "formatters": {
261-
# "verbose": {
262-
# "format": "{levelname} {asctime} {module} {process:d} {thread:d} {message}",
263-
# "style": "{",
264-
# },
265-
# "simple": {
266-
# "format": "{levelname} {message}",
267-
# "style": "{",
268-
# },
269-
# },
270-
# "handlers": {
271-
# "console": {
272-
# "class": "logging.StreamHandler",
273-
# "formatter": "verbose",
274-
# },
275-
# },
276-
# "root": {
277-
# "handlers": ["console"],
278-
# "level": "INFO",
279-
# },
280-
# }
257+
LOGGING = {
258+
"version": 1,
259+
"disable_existing_loggers": False,
260+
"formatters": {
261+
"verbose": {
262+
"format": "{levelname} {asctime} {module} {process:d} {thread:d} {message}",
263+
"style": "{",
264+
},
265+
"simple": {
266+
"format": "{levelname} {message}",
267+
"style": "{",
268+
},
269+
},
270+
"handlers": {
271+
"console": {
272+
"class": "logging.StreamHandler",
273+
"formatter": "verbose",
274+
},
275+
},
276+
"root": {
277+
"handlers": ["console"],
278+
"level": "INFO",
279+
},
280+
}

0 commit comments

Comments
 (0)