Skip to content

Commit e0b7c23

Browse files
committed
fix mock test setup to return string instead of mocked response object
1 parent e8b0fc1 commit e0b7c23

1 file changed

Lines changed: 3 additions & 12 deletions

File tree

server/api/views/uploadFile/test_title.py

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,7 @@ def test_falls_back_to_chatgpt_if_no_title_found(self, mock_openAI):
5959
doc.metadata = {"title": None}
6060
doc[0].get_text.return_value = []
6161

62-
mock_response = MagicMock()
63-
mock_response.choices = [MagicMock()]
64-
mock_response.choices[0].message.content = "A Study Regarding The Efficacy of Drugs"
65-
mock_openAI.return_value = mock_response
62+
mock_openAI.return_value = "A Study Regarding The Efficacy of Drugs"
6663

6764
title.generate_title(doc)
6865

@@ -74,10 +71,7 @@ def test_strips_quotes_from_openai_title(self, mock_openAI):
7471
doc.metadata = {"title": None}
7572
doc[0].get_text.return_value = []
7673

77-
mock_response = MagicMock()
78-
mock_response.choices = [MagicMock()]
79-
mock_response.choices[0].message.content = '"Updated CANMAT/ISBD Guidelines for Treating Mixed Features in Bipolar Disorder"'
80-
mock_openAI.return_value = mock_response
74+
mock_openAI.return_value = '"Updated CANMAT/ISBD Guidelines for Treating Mixed Features in Bipolar Disorder"'
8175

8276
result = title.generate_title(doc)
8377

@@ -89,10 +83,7 @@ def test_truncates_long_openai_title(self, mock_openAI):
8983
doc.metadata = {"title": None}
9084
doc[0].get_text.return_value = []
9185

92-
mock_response = MagicMock()
93-
mock_response.choices = [MagicMock()]
94-
mock_response.choices[0].message.content = "A" * 300
95-
mock_openAI.return_value = mock_response
86+
mock_openAI.return_value = "A" * 300
9687

9788
result = title.generate_title(doc)
9889

0 commit comments

Comments
 (0)