Updated code in regards to recommendations

Author: Martin Boje Carpentier

src/GeoJSON.Text.Test.Benchmark/SerializeAndDeserialize.cs

@@ -11,10 +11,10 @@ public class SerializeAndDeserialize
         string fileContents = "";
 
         // GeoJson.NET
-        private Net.Feature.FeatureCollection featureCollectionGeoJsonNET = new Net.Feature.FeatureCollection();
+        private readonly Net.Feature.FeatureCollection featureCollectionGeoJsonNET = new Net.Feature.FeatureCollection();
 
         // GeoJson.Text
-        private Text.Feature.FeatureCollection featureCollectionGeoJsonTEXT = new Text.Feature.FeatureCollection();
+        private readonly Text.Feature.FeatureCollection featureCollectionGeoJsonTEXT = new Text.Feature.FeatureCollection();
 
         [Params(1000, 10000)]
         public int N;

src/GeoJSON.Text/Converters/PositionEnumerableConverter.cs

@@ -14,7 +14,7 @@ namespace GeoJSON.Text.Converters
     /// </summary>
     public class PositionEnumerableConverter : JsonConverter<IReadOnlyCollection<IPosition>>
     {
-        private static readonly PositionConverter PositionConverter = new PositionConverter();
+        private static readonly PositionConverter PositionConverter = new();
 
         /// <summary>
         ///     Determines whether this instance can convert the specified object type.

src/GeoJSON.Text/Feature/Feature.cs

@@ -271,7 +271,7 @@ private static Dictionary<string, object> GetDictionaryOfPublicProperties(object
 
         public bool Equals(Feature<TGeometry> other)
         {
-            if (ReferenceEquals(null, other)) return false;
+            if (other is null) return false;
             if (ReferenceEquals(this, other)) return true;
 
             if (Geometry == null && other.Geometry == null)
@@ -294,7 +294,7 @@ public bool Equals(Feature<TGeometry> other)
 
         public override bool Equals(object obj)
         {
-            if (ReferenceEquals(null, obj)) return false;
+            if (obj is null) return false;
             if (ReferenceEquals(this, obj)) return true;
             return obj.GetType() == GetType() && Equals((Feature<TGeometry>) obj);
         }
@@ -311,7 +311,7 @@ public override int GetHashCode()
 
         public static bool operator !=(Feature<TGeometry> left, Feature<TGeometry> right)
         {
-            return !(left?.Equals(right) ?? ReferenceEquals(null, right));
+            return !(left?.Equals(right) ?? right is null);
         }
     }
 }

src/GeoJSON.Text/GeoJSONObject.cs

@@ -15,7 +15,7 @@ namespace GeoJSON.Text
     /// </summary>
     public abstract class GeoJSONObject : IGeoJSONObject, IEqualityComparer<GeoJSONObject>, IEquatable<GeoJSONObject>
     {
-        internal static readonly DoubleTenDecimalPlaceComparer DoubleComparer = new DoubleTenDecimalPlaceComparer();
+        internal static readonly DoubleTenDecimalPlaceComparer DoubleComparer = new();
 
         /// <summary>
         ///     Gets or sets the (optional)

src/GeoJSON.Text/Geometry/GeometryCollection.cs

@@ -20,7 +20,7 @@ public class GeometryCollection : GeoJSONObject, IGeometryObject, IEqualityCompa
         /// <summary>
         /// Initializes a new instance of the <see cref="GeometryCollection" /> class.
         /// </summary>
-        public GeometryCollection() : this(new Array.Empty[0])
+        public GeometryCollection() : this(Array.Empty<IGeometryObject>())
         {
         }
 
@@ -85,7 +85,7 @@ public bool Equals(GeometryCollection left, GeometryCollection right)
             {
                 return true;
             }
-            if (ReferenceEquals(null, right))
+            if (right is null)
             {
                 return false;
             }

src/GeoJSON.Text/Geometry/LineString.cs

@@ -29,7 +29,7 @@ public LineString()
         //[JsonConstructor]
         public LineString(IEnumerable<IEnumerable<double>> coordinates)
         : this(coordinates?.Select(latLongAlt => (IPosition)latLongAlt.ToPosition())
-               ?? throw new ArgumentException(nameof(coordinates)))
+               ?? throw new ArgumentNullException(nameof(coordinates)))
         {
         }
 
@@ -131,7 +131,7 @@ public bool Equals(LineString left, LineString right)
             {
                 return true;
             }
-            if (ReferenceEquals(null, right))
+            if (right is null)
             {
                 return false;
             }

src/GeoJSON.Text/Geometry/MultiLineString.cs

@@ -95,7 +95,7 @@ public bool Equals(MultiLineString left, MultiLineString right)
             {
                 return true;
             }
-            if (ReferenceEquals(null, right))
+            if (right is null)
             {
                 return false;
             }

src/GeoJSON.Text/Geometry/MultiPoint.cs

@@ -89,7 +89,7 @@ public bool Equals(MultiPoint left, MultiPoint right)
             {
                 return true;
             }
-            if (ReferenceEquals(null, right))
+            if (right is null)
             {
                 return false;
             }

src/GeoJSON.Text/Geometry/Position.cs

@@ -12,7 +12,7 @@ namespace GeoJSON.Text.Geometry
     /// </summary>
     public class Position : IPosition, IEqualityComparer<Position>, IEquatable<Position>
     {
-        private static readonly DoubleTenDecimalPlaceComparer DoubleComparer = new DoubleTenDecimalPlaceComparer();
+        private static readonly DoubleTenDecimalPlaceComparer DoubleComparer = new();
 
         /// <summary>
         /// Initializes a new instance of the <see cref="Position" /> class.