fix: accessTokenForPersonalAccessKey when using env config (#363)

* Fix accessTokenForPersonalAccessKey when using env config

* go with option 1

* fix condition and add test

Author: brandenrodgers

config/__tests__/config.test.ts

@@ -441,6 +441,18 @@ describe('config/index', () => {
 
       expect(() => updateConfigAccount(OAUTH_ACCOUNT)).toThrow();
     });
+
+    it('skips updating config file when using environment variables', () => {
+      mockConfig();
+      process.env[ENVIRONMENT_VARIABLES.USE_ENVIRONMENT_HUBSPOT_CONFIG] =
+        'true';
+
+      const newAccount = { ...PAK_ACCOUNT, name: 'new-name' };
+
+      updateConfigAccount(newAccount);
+
+      expect(mockFs.writeFileSync).not.toHaveBeenCalled();
+    });
   });
 
   describe('setConfigAccountAsDefault()', () => {

config/index.ts

@@ -7,6 +7,7 @@ import {
   GLOBAL_CONFIG_PATH,
   HUBSPOT_CONFIG_OPERATIONS,
   MIN_HTTP_TIMEOUT,
+  ENVIRONMENT_VARIABLES,
 } from '../constants/config';
 import { HubSpotConfigAccount } from '../types/Accounts';
 import {
@@ -390,6 +391,10 @@ export function addConfigAccount(accountToAdd: HubSpotConfigAccount): void {
 export function updateConfigAccount(
   updatedAccount: HubSpotConfigAccount
 ): void {
+  // Skip updating the config file if we're using environment variables
+  if (process.env[ENVIRONMENT_VARIABLES.USE_ENVIRONMENT_HUBSPOT_CONFIG]) {
+    return;
+  }
   if (!validateConfigAccount(updatedAccount)) {
     throw new HubSpotConfigError(
       i18n('config.updateConfigAccount.invalidAccount', {