fix: handle undefined shell variables in GitHub workflows

This improves the robustness of workflow scripts by adding default values for undefined count variables and adds a check_issues script for monitoring workflow patterns.

Author: amazon-q-developer[bot]

.github/workflows/auto-copilot-code-cleanliness-review.yml

@@ -60,7 +60,7 @@ jobs:
               ! -path "*/build/*" \
               ! -path "*/.venv/*" \
               ! -path "*/vendor/*" \
-              -exec sh -c 'count=$(grep -c "$1" "$2" 2>/dev/null || echo 0); if [ "$count" -gt 20 ]; then echo "$count definitions in $2"; fi' _ "$pattern" {} \; \
+              -exec sh -c 'count=$(grep -c "$1" "$2" 2>/dev/null || echo 0); count=${count:-0}; if [ "$count" -gt 20 ]; then echo "$count definitions in $2"; fi' _ "$pattern" {} \; \
               2>/dev/null || true
           done | sort -rn >> /tmp/analysis.md
           

.github/workflows/auto-copilot-functionality-docs-review.yml

@@ -181,6 +181,11 @@ jobs:
               class_count=$(grep -c "^class " "$file" 2>/dev/null || echo 0)
               docstring_count=$(grep -c '"""' "$file" 2>/dev/null || echo 0)
               
+              # Ensure variables are numeric
+              func_count=${func_count:-0}
+              class_count=${class_count:-0}
+              docstring_count=${docstring_count:-0}
+              
               total=$((func_count + class_count))
               if [ $total -gt 0 ] && [ $docstring_count -eq 0 ]; then
                 echo "⚠️ $file: $total definitions, no docstrings" >> /tmp/doc-analysis.md
@@ -202,6 +207,11 @@ jobs:
               class_count=$(grep -c "^class " "$file" 2>/dev/null || echo 0)
               jsdoc_count=$(grep -c '/\*\*' "$file" 2>/dev/null || echo 0)
               
+              # Ensure variables are numeric
+              func_count=${func_count:-0}
+              class_count=${class_count:-0}
+              jsdoc_count=${jsdoc_count:-0}
+              
               total=$((func_count + class_count))
               if [ $total -gt 5 ] && [ $jsdoc_count -eq 0 ]; then
                 echo "⚠️ $file: ~$total definitions, no JSDoc comments" >> /tmp/doc-analysis.md

check_issues.sh

@@ -0,0 +1,16 @@
+#!/bin/bash
+
+echo "=== Searching for remaining shell arithmetic operations ==="
+grep -r '\$((.*))' .github/workflows/ || echo "No shell arithmetic found"
+
+echo ""
+echo "=== Searching for remaining GitHub Copilot actions ==="
+grep -r 'github/copilot' .github/workflows/ || echo "No GitHub Copilot actions found"
+
+echo ""
+echo "=== Searching for remaining shell arithmetic patterns ==="
+grep -r '\$(' .github/workflows/ | grep -E '(count|total).*=' || echo "No problematic patterns found"
+
+echo ""
+echo "=== Checking for any uses: statements with copilot ==="
+grep -r 'uses:.*copilot' .github/workflows/ || echo "No copilot uses statements found"