Skip to content

Commit d745324

Browse files
committed
fix generator to put optional parameters after mandatatory parameters
1 parent 94e00c4 commit d745324

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

cdp/network.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2850,9 +2850,9 @@ def enable_reporting_api(
28502850

28512851

28522852
def load_network_resource(
2853-
frame_id: typing.Optional[page.FrameId] = None,
28542853
url: str,
2855-
options: LoadNetworkResourceOptions
2854+
options: LoadNetworkResourceOptions,
2855+
frame_id: typing.Optional[page.FrameId] = None
28562856
) -> typing.Generator[T_JSON_DICT,T_JSON_DICT,LoadNetworkResourcePageResult]:
28572857
'''
28582858
Fetches the resource and returns the content.

generator/generate.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,8 @@ def generate_code(self) -> str:
596596
if self.parameters:
597597
code += '\n'
598598
code += indent(
599-
',\n'.join(p.generate_code() for p in self.parameters), 8)
599+
',\n'.join([p.generate_code() for p in self.parameters if not p.optional] + [p.generate_code() for p in self.parameters if p.optional]),
600+
8)
600601
code += '\n'
601602
code += indent(ret, 4)
602603
else:

0 commit comments

Comments
 (0)