all: Use enum instead of bool argument to mp_handle_pending.

dpgeorge · dpgeorge · commit 0c7726a89c2a · 2026-02-05T00:29:36.000+11:00
This should be a no-op because the enum and bool have the same numeric
value.

Signed-off-by: Damien George &lt;damien@micropython.org&gt;
diff --git a/extmod/network_wiznet5k.c b/extmod/network_wiznet5k.c
@@ -147,7 +147,7 @@ void mpy_wiznet_yield(void) {
     #if MICROPY_PY_THREAD
     MICROPY_THREAD_YIELD();
     #else
-    mp_handle_pending(true);
+    mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
     #endif
 }
 
diff --git a/ports/esp32/modsocket.c b/ports/esp32/modsocket.c
@@ -156,7 +156,7 @@ void socket_events_handler(void) {
 #endif // MICROPY_PY_SOCKET_EVENTS
 
 static inline void check_for_exceptions(void) {
-    mp_handle_pending(true);
+    mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
 }
 
 #if MICROPY_HW_ENABLE_MDNS_QUERIES
diff --git a/ports/esp32/mpconfigport.h b/ports/esp32/mpconfigport.h
@@ -309,7 +309,7 @@ void *esp_native_code_commit(void *, size_t, void *);
 #if MICROPY_PY_THREAD
 #define MICROPY_EVENT_POLL_HOOK \
     do { \
-        mp_handle_pending(true); \
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS); \
         MICROPY_PY_SOCKET_EVENTS_HANDLER \
         MP_THREAD_GIL_EXIT(); \
         ulTaskNotifyTake(pdFALSE, 1); \
@@ -323,7 +323,7 @@ void *esp_native_code_commit(void *, size_t, void *);
 #endif
 #define MICROPY_EVENT_POLL_HOOK \
     do { \
-        mp_handle_pending(true); \
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS); \
         MICROPY_PY_SOCKET_EVENTS_HANDLER \
             MICROPY_PY_WAIT_FOR_INTERRUPT; \
     } while (0);
diff --git a/ports/esp32/mphalport.c b/ports/esp32/mphalport.c
@@ -197,7 +197,7 @@ void mp_hal_delay_ms(mp_uint_t ms) {
     uint64_t dt;
     uint64_t t0 = esp_timer_get_time();
     for (;;) {
-        mp_handle_pending(true);
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
         MICROPY_PY_SOCKET_EVENTS_HANDLER
         MP_THREAD_GIL_EXIT();
         uint64_t t1 = esp_timer_get_time();
@@ -240,7 +240,7 @@ void mp_hal_delay_us(mp_uint_t us) {
         if (dt + pend_overhead < us) {
             // we have enough time to service pending events
             // (don't use MICROPY_EVENT_POLL_HOOK because it also yields)
-            mp_handle_pending(true);
+            mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
         }
     }
 }
diff --git a/ports/esp8266/network_wlan.c b/ports/esp8266/network_wlan.c
@@ -275,7 +275,7 @@ static mp_obj_t esp_scan(mp_obj_t self_in) {
         // esp_scan_list variable to NULL without disabling interrupts
         if (MP_STATE_THREAD(mp_pending_exception) != NULL) {
             esp_scan_list = NULL;
-            mp_handle_pending(true);
+            mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
         }
         ets_loop_iter();
     }
diff --git a/ports/mimxrt/boards/MIMXRT1170_EVK/mpconfigboard.h b/ports/mimxrt/boards/MIMXRT1170_EVK/mpconfigboard.h
@@ -5,7 +5,7 @@
 
 #define MICROPY_EVENT_POLL_HOOK \
     do { \
-        mp_handle_pending(true); \
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS); \
     } while (0);
 
 // MIMXRT1170_EVK has 2 user LEDs
diff --git a/ports/mimxrt/mpconfigport.h b/ports/mimxrt/mpconfigport.h
@@ -224,7 +224,7 @@ extern const struct _mp_obj_type_t network_lan_type;
 #ifndef  MICROPY_EVENT_POLL_HOOK
 #define MICROPY_EVENT_POLL_HOOK \
     do { \
-        mp_handle_pending(true); \
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS); \
         __WFE(); \
     } while (0);
 #endif
diff --git a/ports/nrf/mpconfigport.h b/ports/nrf/mpconfigport.h
@@ -379,7 +379,7 @@ long unsigned int rng_generate_random_word(void);
 
 #define MICROPY_EVENT_POLL_HOOK \
     do { \
-        mp_handle_pending(true); \
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS); \
         __WFI(); \
     } while (0);
 
diff --git a/ports/rp2/mpconfigport.h b/ports/rp2/mpconfigport.h
@@ -137,7 +137,7 @@
 #ifndef MICROPY_PY_THREAD
 #define MICROPY_PY_THREAD                       (1)
 #define MICROPY_PY_THREAD_GIL                   (0)
-#define MICROPY_THREAD_YIELD()                  mp_handle_pending(true)
+#define MICROPY_THREAD_YIELD()                  mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS)
 #endif
 
 // Extended modules
diff --git a/ports/samd/mpconfigport.h b/ports/samd/mpconfigport.h
@@ -170,7 +170,7 @@
 
 #define MICROPY_EVENT_POLL_HOOK \
     do { \
-        mp_handle_pending(true); \
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS); \
         __WFE(); \
     } while (0);
 
diff --git a/ports/stm32/mpconfigport.h b/ports/stm32/mpconfigport.h
@@ -234,7 +234,7 @@ typedef long mp_off_t;
 #if MICROPY_PY_THREAD
 #define MICROPY_EVENT_POLL_HOOK \
     do { \
-        mp_handle_pending(true); \
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS); \
         if (pyb_thread_enabled) { \
             MP_THREAD_GIL_EXIT(); \
             pyb_thread_yield(); \
@@ -248,7 +248,7 @@ typedef long mp_off_t;
 #else
 #define MICROPY_EVENT_POLL_HOOK \
     do { \
-        mp_handle_pending(true); \
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS); \
         __WFI(); \
     } while (0);
 
diff --git a/ports/unix/coverage.c b/ports/unix/coverage.c
@@ -675,7 +675,7 @@ static mp_obj_t extra_coverage(void) {
         mp_sched_unlock();
 
         // shouldn't do anything while scheduler is locked
-        mp_handle_pending(true);
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
 
         // unlock scheduler
         mp_sched_unlock();
@@ -691,7 +691,7 @@ static mp_obj_t extra_coverage(void) {
         mp_sched_keyboard_interrupt();
         nlr_buf_t nlr;
         if (nlr_push(&nlr) == 0) {
-            mp_handle_pending(true);
+            mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
             nlr_pop();
         } else {
             mp_obj_print_exception(&mp_plat_print, MP_OBJ_FROM_PTR(nlr.ret_val));
@@ -700,30 +700,30 @@ static mp_obj_t extra_coverage(void) {
         // setting the keyboard interrupt (twice) and cancelling it during mp_handle_pending
         mp_sched_keyboard_interrupt();
         mp_sched_keyboard_interrupt();
-        mp_handle_pending(false);
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_CLEAR_EXCEPTIONS);
 
         // setting keyboard interrupt and a pending event (intr should be handled first)
         mp_sched_schedule(MP_OBJ_FROM_PTR(&mp_builtin_print_obj), MP_OBJ_NEW_SMALL_INT(10));
         mp_sched_keyboard_interrupt();
         if (nlr_push(&nlr) == 0) {
-            mp_handle_pending(true);
+            mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
             nlr_pop();
         } else {
             mp_obj_print_exception(&mp_plat_print, MP_OBJ_FROM_PTR(nlr.ret_val));
         }
-        mp_handle_pending(true);
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
 
         coverage_sched_function_continue = true;
         mp_sched_schedule_node(&mp_coverage_sched_node, coverage_sched_function);
         for (int i = 0; i < 3; ++i) {
             mp_printf(&mp_plat_print, "loop\n");
-            mp_handle_pending(true);
+            mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
         }
         // Clear this flag to prevent the function scheduling itself again
         coverage_sched_function_continue = false;
         // Will only run the first time through this loop, then not scheduled again
         for (int i = 0; i < 3; ++i) {
-            mp_handle_pending(true);
+            mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
         }
     }
 
diff --git a/ports/unix/main.c b/ports/unix/main.c
@@ -157,14 +157,14 @@ static int execute_from_lexer(int source_kind, const void *source, mp_parse_inpu
         }
 
         mp_hal_set_interrupt_char(-1);
-        mp_handle_pending(true);
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
         nlr_pop();
         return 0;
 
     } else {
         // uncaught exception
         mp_hal_set_interrupt_char(-1);
-        mp_handle_pending(false);
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_CLEAR_EXCEPTIONS);
         return handle_uncaught_exception(nlr.ret_val);
     }
 }
@@ -631,12 +631,12 @@ MP_NOINLINE int main_(int argc, char **argv) {
                 if (nlr_push(&nlr) == 0) {
                     mod = mp_builtin___import__(MP_ARRAY_SIZE(import_args), import_args);
                     mp_hal_set_interrupt_char(-1);
-                    mp_handle_pending(true);
+                    mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
                     nlr_pop();
                 } else {
                     // uncaught exception
                     mp_hal_set_interrupt_char(-1);
-                    mp_handle_pending(false);
+                    mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_CLEAR_EXCEPTIONS);
                     ret = handle_uncaught_exception(nlr.ret_val) & 0xff;
                     break;
                 }
diff --git a/ports/unix/modsocket.c b/ports/unix/modsocket.c
@@ -210,7 +210,7 @@ static mp_obj_t socket_connect(mp_obj_t self_in, mp_obj_t addr_in) {
             int err = errno;
             if (self->blocking) {
                 if (err == EINTR) {
-                    mp_handle_pending(true);
+                    mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
                     continue;
                 }
                 // EINPROGRESS on a blocking socket means the operation timed out
diff --git a/ports/unix/modtime.c b/ports/unix/modtime.c
@@ -95,7 +95,7 @@ static mp_obj_t mp_time_sleep(mp_obj_t arg) {
     tv.tv_sec = (suseconds_t)ipart;
     int res;
     while (1) {
-        mp_handle_pending(true);
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
         MP_THREAD_GIL_EXIT();
         res = sleep_select(0, NULL, NULL, NULL, &tv);
         MP_THREAD_GIL_ENTER();
@@ -114,7 +114,7 @@ static mp_obj_t mp_time_sleep(mp_obj_t arg) {
     #else
     int seconds = mp_obj_get_int(arg);
     for (;;) {
-        mp_handle_pending(true);
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
         MP_THREAD_GIL_EXIT();
         seconds = sleep(seconds);
         MP_THREAD_GIL_ENTER();
diff --git a/ports/unix/mphalport.h b/ports/unix/mphalport.h
@@ -99,7 +99,7 @@ static inline void mp_hal_delay_us(mp_uint_t us) {
             if (ret == -1) { \
                 int err = errno; \
                 if (err == EINTR) { \
-                    mp_handle_pending(true); \
+                    mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS); \
                     continue; \
                 } \
                 raise; \
diff --git a/ports/webassembly/mpconfigport.h b/ports/webassembly/mpconfigport.h
@@ -76,7 +76,7 @@
 
 #define MICROPY_EVENT_POLL_HOOK \
     do { \
-        mp_handle_pending(true); \
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS); \
     } while (0);
 
 // Whether the VM will periodically call mp_js_hook(), which checks for
diff --git a/ports/webassembly/mphalport.h b/ports/webassembly/mphalport.h
@@ -51,7 +51,7 @@ int mp_hal_get_interrupt_char(void);
             if (ret == -1) { \
                 int err = errno; \
                 if (err == EINTR) { \
-                    mp_handle_pending(true); \
+                    mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS); \
                     continue; \
                 } \
                 raise; \
diff --git a/ports/zephyr/mpconfigport.h b/ports/zephyr/mpconfigport.h
@@ -168,15 +168,15 @@ typedef long mp_off_t;
 #if MICROPY_PY_THREAD
 #define MICROPY_EVENT_POLL_HOOK \
     do { \
-        mp_handle_pending(true); \
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS); \
         MP_THREAD_GIL_EXIT(); \
         k_msleep(1); \
         MP_THREAD_GIL_ENTER(); \
     } while (0);
 #else
 #define MICROPY_EVENT_POLL_HOOK \
     do { \
-        mp_handle_pending(true); \
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS); \
         k_msleep(1); \
     } while (0);
 #endif
diff --git a/ports/zephyr/mphalport.c b/ports/zephyr/mphalport.c
@@ -52,7 +52,7 @@ void mp_hal_wait_sem(struct k_sem *sem, uint32_t timeout_ms) {
         k_poll_event_init(&wait_events[1], K_POLL_TYPE_SEM_AVAILABLE, K_POLL_MODE_NOTIFY_ONLY, sem);
     }
     for (;;) {
-        mp_handle_pending(true);
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
         MP_THREAD_GIL_EXIT();
         k_timeout_t wait;
         uint32_t dt = mp_hal_ticks_ms() - t0;
diff --git a/py/profile.c b/py/profile.c
@@ -173,7 +173,7 @@ static mp_obj_t mp_prof_callback_invoke(mp_obj_t callback, prof_callback_args_t
     mp_prof_is_executing = false;
 
     if (MP_STATE_THREAD(mp_pending_exception) != MP_OBJ_NULL) {
-        mp_handle_pending(true);
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
     }
     return top;
 }
diff --git a/py/scheduler.c b/py/scheduler.c
@@ -263,7 +263,7 @@ void mp_event_handle_nowait(void) {
     #else
     // Process any port layer (non-blocking) events.
     MICROPY_INTERNAL_EVENT_HOOK;
-    mp_handle_pending(true);
+    mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
     #endif
 }
 
diff --git a/py/vm.c b/py/vm.c
@@ -1346,7 +1346,7 @@ unwind_jump:;
                 MICROPY_VM_HOOK_LOOP
 
                 // Check for pending exceptions or scheduled tasks to run.
-                // Note: it's safe to just call mp_handle_pending(true), but
+                // Note: it's safe to just call mp_handle_pending(...), but
                 // we can inline the check for the common case where there is
                 // neither.
                 if (
@@ -1368,7 +1368,7 @@ unwind_jump:;
                 #endif
                 ) {
                     MARK_EXC_IP_SELECTIVE();
-                    mp_handle_pending(true);
+                    mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
                 }
 
                 #if MICROPY_PY_THREAD_GIL
diff --git a/shared/runtime/pyexec.c b/shared/runtime/pyexec.c
@@ -137,7 +137,7 @@ static int parse_compile_execute(const void *source, mp_parse_input_kind_t input
             mp_call_function_0(module_fun);
         }
         mp_hal_set_interrupt_char(-1); // disable interrupt
-        mp_handle_pending(true); // handle any pending exceptions (and any callbacks)
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);
         nlr_pop();
         ret = PYEXEC_NORMAL_EXIT;
         if (exec_flags & EXEC_FLAG_PRINT_EOF) {
@@ -146,7 +146,7 @@ static int parse_compile_execute(const void *source, mp_parse_input_kind_t input
     } else {
         // uncaught exception
         mp_hal_set_interrupt_char(-1); // disable interrupt
-        mp_handle_pending(false); // clear any pending exceptions (and run any callbacks)
+        mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_CLEAR_EXCEPTIONS);
 
         if (exec_flags & EXEC_FLAG_SOURCE_IS_READER) {
             const mp_reader_t *reader = source;

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ void mpy_wiznet_yield(void) {`
`147`	`147`	`#if MICROPY_PY_THREAD`
`148`	`148`	`MICROPY_THREAD_YIELD();`
`149`	`149`	`#else`
`150`		`- mp_handle_pending(true);`
	`150`	`+ mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);`
`151`	`151`	`#endif`
`152`	`152`	`}`
`153`	`153`
Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ void socket_events_handler(void) {`
`156`	`156`	`#endif // MICROPY_PY_SOCKET_EVENTS`
`157`	`157`
`158`	`158`	`static inline void check_for_exceptions(void) {`
`159`		`- mp_handle_pending(true);`
	`159`	`+ mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);`
`160`	`160`	`}`
`161`	`161`
`162`	`162`	`#if MICROPY_HW_ENABLE_MDNS_QUERIES`
Original file line number	Diff line number	Diff line change
`@@ -197,7 +197,7 @@ void mp_hal_delay_ms(mp_uint_t ms) {`
`197`	`197`	`uint64_t dt;`
`198`	`198`	`uint64_t t0 = esp_timer_get_time();`
`199`	`199`	`for (;;) {`
`200`		`- mp_handle_pending(true);`
	`200`	`+ mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);`
`201`	`201`	`MICROPY_PY_SOCKET_EVENTS_HANDLER`
`202`	`202`	`MP_THREAD_GIL_EXIT();`
`203`	`203`	`uint64_t t1 = esp_timer_get_time();`
`@@ -240,7 +240,7 @@ void mp_hal_delay_us(mp_uint_t us) {`
`240`	`240`	`if (dt + pend_overhead < us) {`
`241`	`241`	`// we have enough time to service pending events`
`242`	`242`	`// (don't use MICROPY_EVENT_POLL_HOOK because it also yields)`
`243`		`- mp_handle_pending(true);`
	`243`	`+ mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);`
`244`	`244`	`}`
`245`	`245`	`}`
`246`	`246`	`}`
Original file line number	Diff line number	Diff line change
`@@ -275,7 +275,7 @@ static mp_obj_t esp_scan(mp_obj_t self_in) {`
`275`	`275`	`// esp_scan_list variable to NULL without disabling interrupts`
`276`	`276`	`if (MP_STATE_THREAD(mp_pending_exception) != NULL) {`
`277`	`277`	`esp_scan_list = NULL;`
`278`		`- mp_handle_pending(true);`
	`278`	`+ mp_handle_pending(MP_HANDLE_PENDING_CALLBACKS_AND_EXCEPTIONS);`
`279`	`279`	`}`
`280`	`280`	`ets_loop_iter();`
`281`	`281`	`}`