Avoid accessing .data field of strings

This is needed to avoid breakage due to changed String representation
in Julia 0.6. Note that we still need to access the .data field
of LegacyStrings types since the Vector() method for them goes through
String, which defeats the purpose of getting UTF-16 or UTF-32 data.

Author: nalimilan

deps/build.jl

@@ -18,9 +18,9 @@ function validate_iconv(n, h)
     cd == Ptr{Void}(-1) && return false
 
     s = "café"
-    a = similar(s.data)
-    inbufptr = Ref{Ptr{UInt8}}(pointer(s.data))
-    inbytesleft = Ref{Csize_t}(length(s.data))
+    a = Vector{UInt8}(sizeof(s))
+    inbufptr = Ref{Ptr{UInt8}}(pointer(s))
+    inbytesleft = Ref{Csize_t}(sizeof(s))
     outbufptr = Ref{Ptr{UInt8}}(pointer(a))
     outbytesleft = Ref{Csize_t}(length(a))
     ret = ccall(Libdl.dlsym_e(h, "iconv"), Csize_t,

test/runtests.jl

@@ -29,25 +29,25 @@ for (s, enc) in (("noël", "ISO-8859-1"),
 end
 
 # Test that attempt to close stream in the middle of incomplete sequence throws
-let s = "a string チャネルパートナーの選択"
+let s = "a string チャネルパートナーの選択", a = Vector{UInt8}(s)
     # First, correct version
     p = StringEncoder(IOBuffer(), "UTF-16LE")
-    write(p, s.data)
+    write(p, a)
     close(p)
     # Test that closed pipe behaves correctly
     @test_throws ArgumentError write(p, 'a')
 
     b = IOBuffer()
     p = StringEncoder(b, "UTF-16LE")
     @test string(p) == "StringEncoder{UTF-8, UTF-16LE}($(string(b)))"
-    write(p, s.data[1:10])
+    write(p, a[1:10])
     @test_throws IncompleteSequenceError close(p)
     # Test that closed pipe behaves correctly even after an error
     @test_throws ArgumentError write(p, 'a')
 
     # This time, call show
     p = StringEncoder(IOBuffer(), "UTF-16LE")
-    write(p, s.data[1:10])
+    write(p, a[1:10])
     try
         close(p)
     catch err