Skip to content

Commit c76ec38

Browse files
virtio-msg: name STRICT_CONFIG_GENERATION in generation fields (Manos Pitsidianakis)
Manos Pitsidianakis noted that the generation-field comments should say explicitly which negotiated feature controls the zero value. Update the GET_CONFIG, SET_CONFIG, and EVENT_CONFIG generation field comments to refer directly to VIRTIO_MSG_F_STRICT_CONFIG_GENERATION instead of saying only "if not negotiated". Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
1 parent 103847d commit c76ec38

1 file changed

Lines changed: 12 additions & 4 deletions

File tree

transport-msg.tex

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1335,7 +1335,9 @@ \subsubsection{Overview}
13351335
};
13361336

13371337
struct virtio_msg_get_config_resp {
1338-
le32 generation; /* generation count, or 0 if not negotiated */
1338+
le32 generation; /* generation count, or 0 if
1339+
* VIRTIO_MSG_F_STRICT_CONFIG_GENERATION is not
1340+
* negotiated */
13391341
le32 offset; /* echoed offset */
13401342
le32 length; /* echoed length */
13411343
u8 data[]; /* configuration payload */
@@ -1371,14 +1373,18 @@ \subsubsection{Overview}
13711373

13721374
\begin{lstlisting}
13731375
struct virtio_msg_set_config_req {
1374-
le32 generation; /* driver's view, or 0 if not negotiated */
1376+
le32 generation; /* driver's view, or 0 if
1377+
* VIRTIO_MSG_F_STRICT_CONFIG_GENERATION is not
1378+
* negotiated */
13751379
le32 offset; /* byte offset being written */
13761380
le32 length; /* number of bytes written */
13771381
u8 data[]; /* configuration payload */
13781382
};
13791383

13801384
struct virtio_msg_set_config_resp {
1381-
le32 generation; /* resulting count, or 0 if not negotiated */
1385+
le32 generation; /* resulting count, or 0 if
1386+
* VIRTIO_MSG_F_STRICT_CONFIG_GENERATION is not
1387+
* negotiated */
13821388
le32 offset; /* echoed offset */
13831389
le32 length; /* bytes applied (0 if rejected) */
13841390
u8 data[]; /* echoed data, omitted when length is 0 */
@@ -1677,7 +1683,9 @@ \subsubsection{Overview}
16771683
\begin{lstlisting}
16781684
struct virtio_msg_event_config {
16791685
le32 device_status; /* new device status value */
1680-
le32 generation; /* generation count, or 0 if not negotiated */
1686+
le32 generation; /* generation count, or 0 if
1687+
* VIRTIO_MSG_F_STRICT_CONFIG_GENERATION is not
1688+
* negotiated */
16811689
le32 offset; /* configuration offset */
16821690
le32 length; /* number of bytes in affected range */
16831691
u8 data[]; /* optional configuration data */

0 commit comments

Comments
 (0)