Skip to content

Commit fb00064

Browse files
committed
virtio-msg: fix-up response matching as discussed Oct 23
Simplify the response matching as discussed in the PR and in the Oct 23 meeting. * Bus messages have a dev_num and it is normally 0 so we don't need to say that matching dev_num if only for transport messages. * Drop msg_id from matching. Altough the msg_id would normally match there may be some cases where it would not. The token field should be unique for a given dev_num. * This simplifys the description of the matching tuple as well Signed-off-by: Bill Mills <bill.mills@linaro.org>
1 parent ae1a63c commit fb00064

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

transport-msg.tex

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -363,22 +363,18 @@ \subsubsection{Message Correlation}
363363
The token field in the message header is part of a tuple that is unique during
364364
a request to response interval.
365365
\begin{itemize}
366-
\item Bus Message tuple: ( 1, 0, \field{token} ).
367-
\item Transport Message tuple: ( 0, \field{dev_num}, \field{token} ).
366+
\item Message tuple: ( \field{dev_num}, \field{token} ).
368367
\end{itemize}
369368

370369
Rules:
371370
\begin{itemize}
372371
\item The request originator assigns a non-zero \field{token} for every
373372
request such that the tuple is unique for all inflight requests.
374373
\item Event (one-way) messages \textbf{MUST} set \field{token}=0
375-
\item A response \textbf{MUST} echo \field{token}, \field{dev_num} (for
376-
transport), and \field{msg_id}.
374+
\item A response \textbf{MUST} echo \field{token} and \field{dev_num}.
377375
\item Reception of unknown or already completed correlation tuples
378376
\textbf{SHOULD} result in discarding the response without further protocol
379377
action.
380-
\item Implementations \textbf{MAY} deliver responses out of order unless a
381-
specific message definition mandates ordering.
382378
\end{itemize}
383379

384380
\subsection{Bus Operation}

0 commit comments

Comments
 (0)