tighten up logger config logic and enumerations

Author: ghukill

timdex_dataset_api/config.py

@@ -14,10 +14,9 @@ def configure_logger(name: str) -> logging.Logger:
     logger = logging.getLogger(name)
 
     # set logger level if env var 'TDA_LOG_LEVEL' is set
-    log_level = os.getenv("TDA_LOG_LEVEL")
-    if log_level:
+    if log_level := os.getenv("TDA_LOG_LEVEL"):
         log_level = log_level.strip().upper()
-        if log_level not in ["DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL"]:
+        if log_level not in logging.getLevelNamesMapping():
             raise ValueError(f"Invalid log level: '{log_level}'")
         logger.setLevel(getattr(logging, log_level))
 

timdex_dataset_api/dataset.py

@@ -363,8 +363,7 @@ def create_record_batches(
             batch = pa.RecordBatch.from_pylist(
                 [record.to_dict() for record in record_batch]
             )
-            message = f"Yielding batch {i+1} for dataset writing."
-            logger.debug(message)
+            logger.debug(f"Yielding batch {i+1} for dataset writing.")
             yield batch
 
     def log_write_statistics(self, start_time: float) -> None: