Skip to content

Commit 2ba36a4

Browse files
authored
Merge pull request #162 from MITLibraries/TIMX-515-hotfix
TIMX 515 - dependency hotfix
2 parents 781e4e0 + e8e97b8 commit 2ba36a4

3 files changed

Lines changed: 63 additions & 60 deletions

File tree

Pipfile.lock

Lines changed: 58 additions & 58 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,10 @@ dependencies = [
2525
"attrs",
2626
"boto3",
2727
"duckdb",
28+
"duckdb_engine",
2829
"pandas",
2930
"pyarrow",
31+
"sqlalchemy"
3032
]
3133

3234
[project.optional-dependencies]

timdex_dataset_api/utils.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import boto3
1212
from duckdb.duckdb import DuckDBPyConnection # type: ignore[import-untyped]
1313
from duckdb_engine import ConnectionWrapper
14-
from mypy_boto3_s3.service_resource import S3ServiceResource
1514
from sqlalchemy import (
1615
MetaData,
1716
Table,
@@ -20,6 +19,8 @@
2019
)
2120

2221
if TYPE_CHECKING:
22+
from mypy_boto3_s3.service_resource import S3ServiceResource
23+
2324
from timdex_dataset_api.dataset import DatasetFilters
2425

2526
logger = logging.getLogger(__name__)
@@ -31,7 +32,7 @@ def __init__(
3132
) -> None:
3233
self.resource = self._create_resource()
3334

34-
def _create_resource(self) -> S3ServiceResource:
35+
def _create_resource(self) -> "S3ServiceResource":
3536
"""Instantiate a boto3 S3 resource.
3637
3738
If env var MINIO_S3_ENDPOINT_URL is set, assume using local set of MinIO env vars.

0 commit comments

Comments
 (0)