Skip to content

Commit 0115684

Browse files
authored
Merge pull request #537 from OP-TED/feature/TED4-161
updated work_title display in package exported mets_dmd file
2 parents 1647398 + af6ddf1 commit 0115684

5 files changed

Lines changed: 9 additions & 8 deletions

File tree

ted_sws/notice_packager/resources/templates/mets_xml_dmd_rdf.jinja2

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<cdm:work_created_by_agent rdf:resource="&cellar-authority;corporate-body/{{ work.created_by_agent }}"/>
2121
<cdm:procurement_public_number_document_in_official-journal rdf:datatype="http://www.w3.org/2001/XMLSchema#string">{{ notice.public_number_document }}</cdm:procurement_public_number_document_in_official-journal>
2222
<cdm:procurement_public_number_edition rdf:datatype="http://www.w3.org/2001/XMLSchema#positiveInteger">{{ notice.public_number_edition }}</cdm:procurement_public_number_edition>
23-
{% for lang in mets.languages %}
23+
{% for lang in work.title %}
2424
<cdm:work_title xml:lang="{{ lang }}">{{ work.title[lang] }}</cdm:work_title>
2525
{% endfor %}
2626
<cdm:datetime_transmission rdf:datatype="http://www.w3.org/2001/XMLSchema#dateTime">{{ work.datetime_transmission }}</cdm:datetime_transmission>
@@ -43,7 +43,7 @@
4343
{# <rdf:type rdf:resource="http://publications.europa.eu/ontology/cdm#expression"/> #}
4444
<rdf:type rdf:resource="http://publications.europa.eu/ontology/cdm#expression_procurement_public"/>
4545
<cdm:expression_belongs_to_work rdf:resource="&resource;ted/{{ work.identifier }}"/>
46-
{% for lang in mets.languages %}
46+
{% for lang in expression.title %}
4747
<cdm:expression_title xml:lang="{{ lang }}">{{ expression.title[lang] }}</cdm:expression_title>
4848
{% endfor %}
4949
<cdm:expression_uses_language rdf:resource="&cellar-authority;language/{{ expression.uses_language }}"/>

ted_sws/notice_packager/services/metadata_transformer.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,9 @@ def from_notice_metadata(cls, notice_metadata: NormalisedMetadata) -> PackagerMe
7070
metadata.work.resource_type = PROCUREMENT_NOTICE
7171
metadata.work.date_document = publication_date
7272
metadata.work.uri = publication_notice_uri(metadata.notice.id, notice_metadata)
73-
# TODO: If no title found in english get a random one
74-
title_search = [title.text for title in notice_metadata.title if title.language == LANGUAGE.upper()]
75-
if len(title_search) > 0:
76-
metadata.work.title = {LANGUAGE: title_search[0]}
73+
metadata.work.title = {}
74+
if notice_metadata.title:
75+
metadata.work.title = {title[1]: title[0] for title in notice_metadata.title}
7776
metadata.work.dataset_version = _date.strftime('%Y%m%d') + '-' + _revision
7877
metadata.work.procurement_public_issued_by_country = notice_metadata.country_of_buyer
7978
# metadata.work.procurement_public_url_etendering = notice_metadata.uri_list

tests/test_data/notice_packager/template_metadata.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@
3939
"dataset_published_by_agent": "EURUN",
4040
"datetime_transmission": "2023-03-09T18:28:54.806241",
4141
"title": {
42-
"en": "Construction work"
42+
"en": "Construction work",
43+
"ro": "Lucrari de constructie"
4344
},
4445
"date_creation": "2023-03-09",
4546
"concept_type_dataset": "TEST_DATA",

tests/test_data/notice_packager/templates/2021_S_004_003545_0.mets.xml.dmd.rdf

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
<cdm:procurement_public_number_edition rdf:datatype="http://www.w3.org/2001/XMLSchema#positiveInteger">2021004</cdm:procurement_public_number_edition>
2323

2424
<cdm:work_title xml:lang="en">Construction work</cdm:work_title>
25+
26+
<cdm:work_title xml:lang="ro">Lucrari de constructie</cdm:work_title>
2527

2628
<cdm:datetime_transmission rdf:datatype="http://www.w3.org/2001/XMLSchema#dateTime">2023-03-09T18:28:54.806241</cdm:datetime_transmission>
2729

tests/unit/notice_packager/test_template_generator.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
# Email: kalean.bl@gmail.com
77

88
""" """
9-
import difflib
109
import re
1110

1211
import pytest

0 commit comments

Comments
 (0)