fix: Make notice daily fetcher being hard failing

Author: duprijil

dags/pipelines/notice_fetcher_pipelines.py

@@ -11,7 +11,6 @@ def notice_fetcher_by_date_pipeline(date_wild_card: str = None) -> List[str]:
     from ted_sws.supra_notice_manager.services.daily_supra_notice_manager import \
         create_and_store_in_mongo_db_daily_supra_notice
     from ted_sws.event_manager.services.log import log_error
-    notice_ids = None
     try:
         date_wild_card = date_wild_card if date_wild_card else (datetime.now() - timedelta(days=1)).strftime("%Y%m%d*")
         notice_publication_date = datetime.strptime(date_wild_card, "%Y%m%d*").date()
@@ -24,6 +23,7 @@ def notice_fetcher_by_date_pipeline(date_wild_card: str = None) -> List[str]:
                                                         ted_publication_date=notice_publication_date)
     except Exception as error:
         log_error(message=str(error))
+        raise error
 
     return notice_ids
 
@@ -35,7 +35,6 @@ def notice_fetcher_by_query_pipeline(query: str = None) -> List[str]:
     from ted_sws.notice_fetcher.adapters.ted_api import TedAPIAdapter, TedRequestAPI
     from ted_sws.notice_fetcher.services.notice_fetcher import NoticeFetcher
     from ted_sws.event_manager.services.log import log_error
-    notice_ids = None
     try:
         ted_api_query = {"query": query}
         mongodb_client = MongoClient(config.MONGO_DB_AUTH_URL)
@@ -44,4 +43,5 @@ def notice_fetcher_by_query_pipeline(query: str = None) -> List[str]:
                                        request_api=TedRequestAPI())).fetch_notices_by_query(query=ted_api_query)
     except Exception as error:
         log_error(message=str(error))
+        raise error
     return notice_ids

ted_sws/notice_fetcher/adapters/ted_api.py

@@ -72,11 +72,10 @@ def __call__(self, api_url: str, api_query: dict) -> dict:
         headers = get_configured_custom_headers(CUSTOM_HEADER)
         response = execute_request_with_retries(
             request_lambda=lambda: requests.post(api_url, json=api_query, headers=headers))
-        if response.ok:
-            response_content = json.loads(response.text)
-            return response_content
-        else:
-            raise Exception(f"The TED-API call failed with: {response}")
+        response.raise_for_status()
+        response_content = json.loads(response.text)
+        return response_content
+
 
 
 class TedAPIAdapter(TedAPIAdapterABC):