Validation Summary Report

Author: Kolea Plesco

ted_sws/core/model/notice.py

@@ -206,8 +206,6 @@ def get_distilled_rdf_validation(self) -> Optional[List[RDFValidationManifestati
         return result
 
     def get_xml_validation(self) -> Optional[List[XMLValidationManifestation]]:
-        if not self.xml_manifestation:
-            return None
         result = []
         if self.xml_manifestation.xpath_coverage_validation:
             result.append(self.xml_manifestation.xpath_coverage_validation)
@@ -320,11 +318,7 @@ def set_xml_validation(self, xml_validation: Union[XPATHCoverageValidationReport
         :param xml_validation:
         :return:
         """
-        if not self.xml_manifestation:
-            raise ValueError("Cannot set the XML validation of a non-existent XML manifestation")
-
         self.xml_manifestation.add_validation(validation=xml_validation)
-
         if self._check_status_is_validated():
             self.update_status_to(NoticeStatus.VALIDATED)
 

tests/unit/core/model/test_notice_validation.py

@@ -8,7 +8,7 @@
 """ """
 
 from ted_sws.core.model.manifestation import XPATHCoverageValidationReport, SHACLTestSuiteValidationReport, \
-    QueriedSHACLShapeValidationResult
+    QueriedSHACLShapeValidationResult, RDFManifestation
 from ted_sws.core.model.notice import NoticeStatus
 
 
@@ -21,19 +21,27 @@ def test_set_notice_validation(publicly_available_notice):
     publicly_available_notice.set_rdf_validation(rdf_validation=shacl_validation)
     publicly_available_notice.set_distilled_rdf_validation(rdf_validation=shacl_validation)
 
+    publicly_available_notice.set_xml_validation(XPATHCoverageValidationReport(
+        object_data="",
+        mapping_suite_identifier=""
+    ))
+
+    publicly_available_notice.set_rdf_validation(rdf_validation=shacl_validation)
+    publicly_available_notice.set_distilled_rdf_validation(rdf_validation=shacl_validation)
+
+    assert publicly_available_notice.status is NoticeStatus.VALIDATED
+    assert publicly_available_notice.mets_manifestation is None
+
+
+def test_set_notice_xml_validation(publicly_available_notice):
     xml_validation = XPATHCoverageValidationReport(
         object_data="",
         mapping_suite_identifier=""
     )
+
     xml_manifestation = publicly_available_notice.xml_manifestation
     xml_manifestation.add_validation(xml_validation)
-    assert publicly_available_notice.xml_manifestation.xpath_coverage_validation
+    assert xml_manifestation.xpath_coverage_validation
     xml_validations = publicly_available_notice.get_xml_validation()
     assert len(xml_validations)
     assert xml_validation in xml_validations
-
-    publicly_available_notice.set_xml_validation(xml_validation)
-
-    assert publicly_available_notice.status is NoticeStatus.VALIDATED
-    assert publicly_available_notice.mets_manifestation is None
-