Skip to content

Commit 50fa51d

Browse files
committed
fix(test): remove fake MS config fixture and logic in pipeline test
The actual fetch of the github repo would get no MS config, and the fake would be adding one. There appears to inconsistency in this test passing locally but failing on the server, so let us remove the MS config part.
1 parent d08b0c6 commit 50fa51d

1 file changed

Lines changed: 1 addition & 9 deletions

File tree

test/e2e/dags/pipelines/test_notice_processor_pipelines.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
notice_validation_pipeline, notice_package_pipeline, notice_publish_pipeline
44
from src.ted_sws.core.model.notice import NoticeStatus
55
from src.ted_sws.data_manager.adapters.notice_repository import NoticeRepository
6-
from src.ted_sws.data_manager.adapters.mapping_package_repository import MappingPackageRepositoryMongoDB
76
from src.ted_sws.mapping_suite_processor.services.mapping_package_processor import \
87
load_mapping_suite_and_packages_from_github_to_mongo_db
98

@@ -12,20 +11,13 @@
1211
NOTICE_ID = "057215-2021"
1312

1413

15-
def test_notice_processor_pipelines(fake_mongodb_client, load_mapping_suite_and_package_fake, mapping_suite):
14+
def test_notice_processor_pipelines(fake_mongodb_client):
1615
load_mapping_suite_and_packages_from_github_to_mongo_db(
1716
mapping_package_name=MAPPING_PACKAGE_NAME,
1817
mongodb_client=fake_mongodb_client,
1918
load_test_data=True
2019
)
2120

22-
# Update GitHub-loaded packages to use the local mapping suite
23-
mapping_package_repository = MappingPackageRepositoryMongoDB(mongodb_client=fake_mongodb_client)
24-
for pkg in mapping_package_repository.list():
25-
if not pkg.mapping_suite_identifier:
26-
pkg.mapping_suite_identifier = mapping_suite.id
27-
mapping_package_repository.update(pkg)
28-
2921
notice_id = NOTICE_ID
3022
notice_repository = NoticeRepository(mongodb_client=fake_mongodb_client)
3123
notice = notice_repository.get(reference=notice_id)

0 commit comments

Comments
 (0)