Skip to content

Commit 75ba112

Browse files
committed
Revert "fix: add guard for mongo client closing by external library"
This reverts commit b45f6f8.
1 parent 9bba453 commit 75ba112

3 files changed

Lines changed: 0 additions & 20 deletions

File tree

src/dags/operators/DagBatchPipelineOperator.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,6 @@
77
from airflow.utils.types import DagRunType
88
from pymongo import MongoClient
99

10-
# WORKAROUND: Disable __del__ in MSSDK's MongoDBRepository to prevent premature client closure
11-
# The MSSDK MongoDBRepository closes the MongoClient in __del__, but it doesn't own the client.
12-
# When the repository is garbage collected between loop iterations, it closes the shared client.
13-
from mapping_suite_sdk.core.adapters.repository import MongoDBRepository as _MSSKDMongoDBRepository
14-
if hasattr(_MSSKDMongoDBRepository, '__del__'):
15-
delattr(_MSSKDMongoDBRepository, '__del__')
16-
1710
from src.dags import RUN_MATERIALISED_VIEW_DAG_PARAM, XCOM_SOURCE_RUN_TYPE_KEY
1811
from src.dags.dags_utils import pull_dag_upstream, push_dag_downstream, get_dag_param, smart_xcom_pull, \
1912
smart_xcom_push

src/ted_sws/data_manager/adapters/mapping_package_repository.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,6 @@
77
from pymongo import MongoClient
88

99
from mapping_suite_sdk.core.adapters.repository import MongoDBRepository, ModelNotFoundError
10-
11-
# WORKAROUND: Disable __del__ in MSSDK's MongoDBRepository to prevent premature client closure
12-
# The MSSDK MongoDBRepository closes the MongoClient in __del__, but it doesn't own the client.
13-
# When the repository is garbage collected, it closes the shared client unexpectedly.
14-
if hasattr(MongoDBRepository, '__del__'):
15-
delattr(MongoDBRepository, '__del__')
1610
from mapping_suite_sdk.mapping_package_v1.models import MappingPackageV1
1711
from mapping_suite_sdk.mapping_package_v2.models import MappingPackageV2
1812
from mapping_suite_sdk.mapping_package_v3.models import MappingPackageV3

src/ted_sws/mapping_suite_processor/services/mapping_package_processor.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,6 @@
44

55
from pymongo import MongoClient
66

7-
# WORKAROUND: Disable __del__ in MSSDK's MongoDBRepository to prevent premature client closure
8-
# The MSSDK MongoDBRepository closes the MongoClient in __del__, but it doesn't own the client.
9-
# When the repository is garbage collected, it closes the shared client unexpectedly.
10-
from mapping_suite_sdk.core.adapters.repository import MongoDBRepository as _MSSKDMongoDBRepository
11-
if hasattr(_MSSKDMongoDBRepository, '__del__'):
12-
delattr(_MSSKDMongoDBRepository, '__del__')
13-
147
from src.ted_sws import config
158
from src.ted_sws.core.model.manifestation import XMLManifestation
169
from src.ted_sws.core.model.notice import Notice

0 commit comments

Comments
 (0)