chore: remove unneeded comments

Author: schivmeister

src/ted_sws/core/model/transform.py

@@ -62,7 +62,6 @@ class NoticeFileResource(FileResource):
 
 class MetadataConstraintsStandardForm(MappingPackageComponent):
     """Metadata constraints structure for Standard forms."""
-    # TODO: MSSDK must fix SF (v1) to have str in model even if data is int
     eforms_subtype: List[str]
     start_date: Optional[List[str]] = None
     end_date: Optional[List[str]] = None
@@ -170,7 +169,6 @@ class MappingPackage(MappingPackageComponent, MappingPackageV3):
     transformation_test_data: Optional[TransformationTestData] = Field(default=None)
     previous_version: Optional[str] = Field(default=None)
 
-    # TODO fix to be forwarded to MSSDK, remove when implemented there
     # Override large/optional collection assets in MSSDK model
     test_results: Optional[TestResultCollectionAsset] = Field(
         default=None,
@@ -206,7 +204,6 @@ def sync_legacy_and_mssdk_fields(self) -> 'MappingPackage':
         setattr(self, "_sync_done", True)
 
         # If MSSDK v3 fields are missing but legacy fields exist, populate from legacy
-        # FIXME: this is a transitional solution for code where the legacy file system package parsing is done
         if self.metadata is None:
             self._populate_mssdk_from_legacy()
 

src/ted_sws/mapping_suite_processor/services/mapping_package_processor.py

@@ -55,7 +55,6 @@ def mapping_package_processor_load_package_in_mongo_db(
         List of notice IDs that were loaded (if load_test_data=True)
     """
     # Update digest
-    # FIXME refactor for MSSDK transformation rule set structure
     update_digest_api_address_for_mapping_package(package)
 
     # Update git hash if provided and field exists
@@ -64,7 +63,6 @@ def mapping_package_processor_load_package_in_mongo_db(
     result_notice_ids = []
 
     # Load test data if requested
-    # FIXME refactor for MSSDK's two-level test data structure
     if load_test_data:
         tests_data = package.transformation_test_data.test_data
         notice_repository = NoticeRepository(mongodb_client=mongodb_client)
@@ -75,7 +73,7 @@ def mapping_package_processor_load_package_in_mongo_db(
             notice_repository.add(notice=notice)
             result_notice_ids.append(notice_id)
     mapping_package_repository_mongo_db = MappingPackageRepositoryMongoDB(mongodb_client=mongodb_client)
-    # FIXME: will throw pymongo.errors.DuplicateKeyError if package with same id exists
+    # will throw pymongo.errors.DuplicateKeyError if package with same id exists
     mapping_package_repository_mongo_db.add(package)
     return result_notice_ids
 
@@ -153,7 +151,6 @@ def load_mapping_suite_and_packages_from_github_to_mongo_db(mongodb_client: Mong
             log_technical_info(
                 message=f"Mapping package '{mssdk_package.id}' (format '{detected_version}' -> '{converted_version}') loaded from folder with success")
             mapping_package = _convert_to_mapping_package(mssdk_package)
-            # FIXME: MSSDK validation is currently done during loading, so we have to catch exceptions from there
             if mssdk_package:
                 log_mapping_package_info(
                     message=f"Mapping package with id={mapping_package.id} is valid for loading in MongoDB!",

test/unit/data_manager/test_mapping_package_repository.py

@@ -79,7 +79,7 @@ def test_mapping_package_repository_in_file_system(file_system_repository_path,
     assert len(result_mapping_packages) == 2
     mapping_package_repository.clear_repository()
 
-# FIXME: during the transition to MSSDK the models for writing will be different, so do a very minimal test on specific fields
+# during the transition to MSSDK the models for writing will be different, so do a very minimal test on specific fields
 def test_inter_transactions_mapping_package_repositories(mongodb_client, file_system_repository_path, fake_mapping_package,
                                                        fake_mapping_package_identifier,
                                                        aggregates_database_name):