Notice Publisher tests fixes

Author: Kolea Plesco

ted_sws/mapping_suite_processor/services/conceptual_mapping_processor.py

@@ -67,9 +67,8 @@ def mapping_suite_processor_from_github_expand_and_load_package_in_mongo_db(mapp
     :param load_test_data:
     :return:
     """
-    default_github_repository_url = "https://github.com/meaningfy-ws/ted-sws-artefacts.git"
     mapping_suite_package_downloader = GitHubMappingSuitePackageDownloader(
-        github_repository_url=config.GITHUB_TED_SWS_ARTEFACTS_URL or default_github_repository_url)
+        github_repository_url=config.GITHUB_TED_SWS_ARTEFACTS_URL)
     with tempfile.TemporaryDirectory() as tmp_dir:
         tmp_dir_path = pathlib.Path(tmp_dir)
         git_last_commit_hash = mapping_suite_package_downloader.download(

ted_sws/notice_validator/services/xpath_coverage_runner.py

@@ -27,8 +27,9 @@ def coverage_notice_xpath_report(notices: List[Notice], mapping_suite_id,
                                  coverage_runner: CoverageRunner = None, xslt_transformer=None,
                                  notice_repository: NoticeRepository = None) -> XPATHCoverageValidationReport:
     if not coverage_runner:
+        mongodb_client = notice_repository.mongodb_client if notice_repository else None
         coverage_runner = CoverageRunner(mapping_suite_id, conceptual_mappings_file_path, xslt_transformer,
-                                         notice_repository.mongodb_client)
+                                         mongodb_client)
     report: XPATHCoverageValidationReport = coverage_runner.coverage_notice_xpath(notices, mapping_suite_id)
     return report
 

tests/unit/notice_validator/test_xpath_coverage_runner.py

@@ -12,6 +12,7 @@
 def test_xpath_coverage_runner(fake_notice_F03, fake_conceptual_mappings_F03_path, fake_xslt_transformer,
                                fake_mapping_suite_F03_id, mongodb_client, fake_mapping_suite_F03_path,
                                invalid_mapping_suite_id):
+    notice_repository = NoticeRepository(mongodb_client=mongodb_client)
     report = coverage_notice_xpath_report([fake_notice_F03], fake_mapping_suite_F03_id,
                                           fake_conceptual_mappings_F03_path, None, fake_xslt_transformer)
     json_report = xpath_coverage_json_report(report)
@@ -30,14 +31,14 @@ def test_xpath_coverage_runner(fake_notice_F03, fake_conceptual_mappings_F03_pat
 
     report = coverage_notice_xpath_report([fake_notice_F03], fake_mapping_suite_F03_id,
                                           fake_conceptual_mappings_F03_path, None, fake_xslt_transformer,
-                                          mongodb_client)
+                                          notice_repository)
     json_report = xpath_coverage_json_report(report)
     assert isinstance(json_report, dict)
 
     with pytest.raises(ValueError):
         coverage_notice_xpath_report([fake_notice_F03], invalid_mapping_suite_id,
                                      None, None, fake_xslt_transformer,
-                                     mongodb_client)
+                                     notice_repository)
 
 
 def test_validate_xpath_coverage_notice_by_id(fake_notice_id, fake_mapping_suite_F03_id,