Merge pull request #418 from OP-TED/feature/TED-1074

Update test_mongodb_client.py

Author: duprijil

tests/e2e/data_manager/test_mongodb_client.py

@@ -8,7 +8,8 @@
 from ted_sws.data_manager.services.create_batch_collection_materialised_view import \
     create_batch_collection_materialised_view, NOTICE_PROCESS_BATCH_COLLECTION_NAME
 from ted_sws.data_manager.services.create_notice_collection_materialised_view import \
-    create_notice_collection_materialised_view, NOTICES_MATERIALISED_VIEW_NAME
+    create_notice_collection_materialised_view, NOTICES_MATERIALISED_VIEW_NAME, create_notice_kpi_collection, \
+    NOTICE_KPI_COLLECTION_NAME
 from ted_sws.data_sampler.services.notice_xml_indexer import index_notice
 from ted_sws.event_manager.adapters.event_handler_config import DAGLoggerConfig
 from ted_sws.event_manager.adapters.event_logger import EventLogger
@@ -165,30 +166,29 @@ def test_create_matview_for_notices(fake_mongodb_client):
     db = mongodb_client[config.MONGO_DB_AGGREGATES_DATABASE_NAME]
     assert NOTICES_MATERIALISED_VIEW_NAME in db.list_collection_names()
     document = db[NOTICES_MATERIALISED_VIEW_NAME].find_one()
-    if document is not None:
-        fields_in_the_materialised_view = document.keys()
-        assert 'form_type' in fields_in_the_materialised_view
-        assert 'form_number' in fields_in_the_materialised_view
-        assert 'eforms_subtype' in fields_in_the_materialised_view
-        assert 'eu_institution' in fields_in_the_materialised_view
-        assert 'extracted_legal_basis_directive' in fields_in_the_materialised_view
-        assert 'legal_basis_directive' in fields_in_the_materialised_view
-        assert 'ojs_type' in fields_in_the_materialised_view
-        assert 'country_of_buyer' in fields_in_the_materialised_view
-        assert 'notice_type' in fields_in_the_materialised_view
-        assert 'xsd_version' in fields_in_the_materialised_view
-        assert 'publication_date' in fields_in_the_materialised_view
-
-    # FIXME: This code don't work with empty mongodb.
-    # create_notice_kpi_collection(mongo_client=mongodb_client)
-    # assert NOTICE_KPI_COLLECTION_NAME in db.list_collection_names()
-    # document = db[NOTICE_KPI_COLLECTION_NAME].find_one()
-    # if document is not None:
-    #     fields_in_the_kpi_collection = document.keys()
-    #     assert 'exec_time' in fields_in_the_kpi_collection
-    #     assert 'form_number' in fields_in_the_kpi_collection
-    #     assert 'eforms_subtype' in fields_in_the_kpi_collection
-    #     assert 'status' in fields_in_the_kpi_collection
+    assert document is not None
+    fields_in_the_materialised_view = document.keys()
+    assert 'form_type' in fields_in_the_materialised_view
+    assert 'form_number' in fields_in_the_materialised_view
+    assert 'eforms_subtype' in fields_in_the_materialised_view
+    assert 'eu_institution' in fields_in_the_materialised_view
+    assert 'extracted_legal_basis_directive' in fields_in_the_materialised_view
+    assert 'legal_basis_directive' in fields_in_the_materialised_view
+    assert 'ojs_type' in fields_in_the_materialised_view
+    assert 'country_of_buyer' in fields_in_the_materialised_view
+    assert 'notice_type' in fields_in_the_materialised_view
+    assert 'xsd_version' in fields_in_the_materialised_view
+    assert 'publication_date' in fields_in_the_materialised_view
+
+    create_notice_kpi_collection(mongo_client=mongodb_client)
+    if NOTICE_KPI_COLLECTION_NAME in db.list_collection_names():
+        document = db[NOTICE_KPI_COLLECTION_NAME].find_one()
+        assert document is not None
+        fields_in_the_kpi_collection = document.keys()
+        assert 'exec_time' in fields_in_the_kpi_collection
+        assert 'form_number' in fields_in_the_kpi_collection
+        assert 'eforms_subtype' in fields_in_the_kpi_collection
+        assert 'status' in fields_in_the_kpi_collection
 
 
 def test_create_matview_for_batches():