Skip to content

Commit d78a813

Browse files
remove Archiver factory
1 parent b963d0e commit d78a813

2 files changed

Lines changed: 2 additions & 13 deletions

File tree

ted_sws/notice_packager/adapters/archiver.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -35,17 +35,6 @@ def process_archive(self, archive_name: Path, files: List[Path], mode: str) -> P
3535
"""
3636

3737

38-
class ArchiverFactory:
39-
@classmethod
40-
def get_archiver(cls, archive_format=ARCHIVE_DEFAULT_FORMAT):
41-
"""Factory Method to return the needed Archiver, based on archive format"""
42-
archivers = {
43-
"zip": ZipArchiver
44-
}
45-
46-
return archivers[archive_format]()
47-
48-
4938
class ZipArchiver(ArchiverABC):
5039
def process_archive(self, archive_name: Path, files: List[Path], mode: str = ARCHIVE_MODE) -> Path:
5140
with ZipFile(archive_name, mode=mode, compression=ARCHIVE_ZIP_COMPRESSION) as archive:

ted_sws/notice_packager/services/notice_packager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
from ted_sws.notice_metadata_processor.model.metadata import ExtractedMetadata
2222
from ted_sws.notice_metadata_processor.services.xml_manifestation_metadata_extractor import \
2323
XMLManifestationMetadataExtractor
24-
from ted_sws.notice_packager.adapters.archiver import ArchiverFactory, ARCHIVE_ZIP_FORMAT
24+
from ted_sws.notice_packager.adapters.archiver import ZipArchiver
2525
from ted_sws.notice_packager.adapters.template_generator import TemplateGenerator
2626
from ted_sws.notice_packager.model.metadata import ACTION_CREATE
2727
from ted_sws.notice_packager.services.metadata_transformer import MetadataTransformer
@@ -115,7 +115,7 @@ def get_archive_name(self) -> str:
115115
return archive_name
116116

117117
def pack(self) -> str:
118-
archiver = ArchiverFactory.get_archiver(ARCHIVE_ZIP_FORMAT)
118+
archiver = ZipArchiver()
119119
archive_path = self.tmp_dir_path / self.get_archive_name()
120120
package_path = archiver.process_archive(archive_path, self.files)
121121
raw_archive_content = package_path.read_bytes()

0 commit comments

Comments
 (0)