Merge pull request swagger-api#961 from Malligarjunan/Issue_948

Fixed Issue_948

Author: gracekarina

modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/processors/ParameterProcessor.java

@@ -83,6 +83,11 @@ public List<Parameter> processParameters(List<Parameter> parameters) {
             if (parameter.get$ref() != null) {
                 RefFormat refFormat = computeRefFormat(parameter.get$ref());
                 final Parameter resolvedParameter = cache.loadRef(parameter.get$ref(), refFormat, Parameter.class);
+                if (parameter.get$ref().startsWith("#") && parameter.get$ref().indexOf("#/components/parameters") <= -1) {
+                    //TODO: Not possible to add warning during resolve doesn't accept result as an input. Hence commented below line.
+                    //result.warning(location, "The parameter should use Reference Object to link to parameters that are defined at the OpenAPI Object's components/parameters.");
+                    continue;
+                }
 
                 if(resolvedParameter == null) {
                     // can't resolve it!
@@ -92,7 +97,7 @@ public List<Parameter> processParameters(List<Parameter> parameters) {
                 // if the parameter exists, replace it
                 boolean matched = false;
                 for(Parameter param : processedPathLevelParameters) {
-                    if(param.getName().equals(resolvedParameter.getName())) {
+                    if(param != null && param.getName() != null && param.getName().equals(resolvedParameter.getName())) {
                         // ref param wins
                         matched = true;
                         break;

modules/swagger-parser-v3/src/test/java/io/swagger/v3/parser/test/OpenAPIV3ParserTest.java

@@ -30,6 +30,7 @@
 import io.swagger.v3.oas.models.parameters.RequestBody;
 import io.swagger.v3.oas.models.responses.ApiResponse;
 import io.swagger.v3.oas.models.security.SecurityScheme;
+import io.swagger.v3.parser.OpenAPIResolver;
 import io.swagger.v3.parser.OpenAPIV3Parser;
 import io.swagger.v3.parser.core.models.AuthorizationValue;
 import io.swagger.v3.parser.core.models.ParseOptions;
@@ -1631,6 +1632,16 @@ public void testIssue931() {
 
     }
 
+    @Test
+    public void testIssue948() {
+        ParseOptions options = new ParseOptions();
+        options.setResolve(true);
+        SwaggerParseResult result = new OpenAPIV3Parser().readLocation("Issue_948.json", null, options);
+        new OpenAPIResolver(result.getOpenAPI()).resolve();
+        assertNotNull(result.getOpenAPI());
+
+    }
+
     public void shouldParseParameters() {
         ParseOptions parseOptions = new ParseOptions();
         parseOptions.setResolveFully(true);

modules/swagger-parser-v3/src/test/resources/Issue_948.json

@@ -0,0 +1,109 @@
+{
+  "openapi":"3.0.0",
+  "info":{
+    "title":"Test",
+    "description":"Test API",
+    "version":"1.0"
+  },
+  "servers":[
+    {
+      "url":"http://localhost:8888/api"
+    }
+  ],
+  "paths":{
+    "/devices":{
+      "get":{
+        "tags":[
+          "devices"
+        ],
+        "summary":"List all Devices",
+        "operationId":"getDevices",
+        "parameters":[
+          {
+            "$ref":"#/components/headers/Content-Type"
+          },
+          {
+            "$ref":"#/components/parameters/idFrom"
+          },
+          {
+            "name":"category",
+            "in":"query",
+            "description":"A request parameter that matches against the device category.",
+            "schema":{
+              "$ref":"#/components/schemas/deviceCategory"
+            }
+          },
+          {
+            "name":"manufacturer",
+            "in":"query",
+            "description":"A request parameter that performs LIKE matching against the device manufacturer.",
+            "schema":{
+              "maxLength":200,
+              "minLength":1,
+              "type":"string",
+              "example":"Sony"
+            }
+          }
+        ],
+        "responses":{
+          "200":{
+            "description":"An array of devices that match the request parameters requested.",
+            "content":{
+              "application/json":{
+                "schema":{
+                  "type":"object",
+                  "properties":{
+                    "device":{
+                      "$ref":"#/components/schemas/device"
+                    }
+                  }
+                }
+              }
+            }
+          }
+        }
+      }
+    }
+  },
+  "components":{
+    "schemas":{
+      "deviceCategory":{
+        "type":"string",
+        "description":"The list of avialable viewer device categories.",
+        "example":"TV",
+        "enum":[
+          "TV",
+          "Phone",
+          "Tablet",
+          "Laptop",
+          "Monitor",
+          "Other"
+        ]
+      },
+      "device":{
+        "type":"string",
+        "description":"Captures the possible states for an analysis."
+      }
+    },
+    "parameters":{
+      "idFrom":{
+        "name":"idFrom",
+        "in":"query",
+        "description":"The lower-bound of a request parameter filtering based on unique object identifier.",
+        "schema":{
+          "type":"integer"
+        }
+      }
+    },
+    "headers":{
+      "Content-Type":{
+        "required":true,
+        "schema":{
+          "type":"string",
+          "example":"application/json;charset=UTF-8",
+          "default":"application/json;charset=UTF-8"
+        }
+      }
+    }
+  }
+}