Skip to content

Commit ef5b8a8

Browse files
Copilotrenemadsen
Copilot
and
renemadsen
committed
Add investigation summary document
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
1 parent cdbccb7 commit ef5b8a8

1 file changed

Lines changed: 105 additions & 0 deletions

File tree

‎PASSKEY_INVESTIGATION_SUMMARY.md‎

Lines changed: 105 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,105 @@
1+
# PassKey Support Investigation - Summary
2+
3+
## Issue Investigated
4+
[dotnet/aspnetcore#64939](https://github.com/dotnet/aspnetcore/issues/64939) - Concern that MySQL providers might not support ASP.NET Core Identity PassKeys in .NET 10 due to the use of `.ToJson()` with complex types including `string[]` arrays.
5+
6+
## Investigation Date
7+
January 7, 2026
8+
9+
## Result
10+
✅ **Pomelo.EntityFrameworkCore.MySql FULLY SUPPORTS PassKeys!**
11+
12+
## What Was Tested
13+
14+
### Test Application
15+
Created a complete sample application at `samples/PassKeyTest` that:
16+
1. Creates an Identity database with PassKey support (Schema Version 3)
17+
2. Inserts PassKey records with complex data including `string[]` arrays
18+
3. Retrieves and validates PassKey data integrity
19+
4. Verifies JSON storage and query capabilities
20+
21+
### Test Environment
22+
- .NET 10.0.101
23+
- Pomelo.EntityFrameworkCore.MySql (current master branch)
24+
- MySqlConnector 2.5.0
25+
- Microsoft.AspNetCore.Identity.EntityFrameworkCore 10.0.1
26+
- MariaDB 11.6.2
27+
28+
### Test Results
29+
All tests passed:
30+
- ✅ Database schema creation including `AspNetUserPasskeys` table
31+
- ✅ JSON column creation (stored as `longtext` on MariaDB, `json` on MySQL 8.0+)
32+
- ✅ Insert PassKey records with `IdentityPasskeyData` containing `string[] Transports`
33+
- ✅ Read PassKey records with full data integrity
34+
- ✅ JSON serialization/deserialization of arrays and complex types
35+
- ✅ Query JSON data using database JSON functions
36+
37+
## Technical Details
38+
39+
### How It Works
40+
Pomelo uses `MySqlStructuralJsonTypeMapping` (located in `src/EFCore.MySql/Storage/Internal/MySqlStructuralJsonTypeMapping.cs`) to handle JSON columns created by `.ToJson()`:
41+
42+
1. **Type Mapping**: Implements `JsonTypeMapping` base class from EF Core
43+
2. **Data Reader**: Uses `DbDataReader.GetString()` to read JSON as string from database
44+
3. **Conversion**: Converts string to `MemoryStream` using UTF-8 encoding for EF Core's JSON processing
45+
4. **Serialization**: Fully supports complex types including arrays, nested objects, byte arrays, etc.
46+
5. **Parameter Handling**: Sets `MySqlDbType.JSON` for proper database parameter configuration
47+
48+
### Database Storage
49+
- **MariaDB**: Stores JSON as `longtext` with JSON validation constraints
50+
- **MySQL 8.0+**: Stores as native `json` type
51+
- Both implementations support JSON functions and queries
52+
53+
### Array Handling
54+
The critical `string[] Transports` property in `IdentityPasskeyData` is correctly handled:
55+
- Serialized to JSON array: `["usb", "nfc", "ble"]`
56+
- Stored in database as valid JSON
57+
- Deserialized back to `string[]` on read
58+
- Maintains array order and all elements
59+
60+
## Conclusion
61+
62+
**The issue reported in dotnet/aspnetcore#64939 does NOT affect Pomelo.EntityFrameworkCore.MySql.**
63+
64+
Pomelo's implementation of `.ToJson()` is complete and robust, handling all required scenarios including:
65+
- Non-primitive types (`string[]`, `byte[]`)
66+
- Complex nested objects
67+
- Nullable properties
68+
- All data types used in `IdentityPasskeyData`
69+
70+
No code changes were needed to the Pomelo implementation. The existing code fully supports PassKeys.
71+
72+
## Documentation Added
73+
74+
1. **Sample Application**: `samples/PassKeyTest/`
75+
- Complete working example
76+
- Demonstrates all PassKey operations
77+
- Includes detailed test output
78+
- Can be run against any MySQL 8.0+ or MariaDB 10.2.7+ instance
79+
80+
2. **Usage Guide**: `docs/PassKey-Support.md`
81+
- How to configure DbContext for PassKeys
82+
- Code examples
83+
- Migration guidance
84+
- Technical details
85+
86+
3. **Sample README**: `samples/PassKeyTest/README.md`
87+
- Test results
88+
- Usage instructions
89+
- Background information
90+
91+
## Recommendation
92+
93+
Users can confidently use Pomelo.EntityFrameworkCore.MySql with ASP.NET Core Identity PassKeys in .NET 10. The provider fully supports all required functionality out of the box.
94+
95+
## Files Modified/Added
96+
97+
- Added: `samples/PassKeyTest/PassKeyTest.csproj`
98+
- Added: `samples/PassKeyTest/Program.cs`
99+
- Added: `samples/PassKeyTest/README.md`
100+
- Added: `docs/PassKey-Support.md`
101+
- Modified: `Directory.Packages.props` (added Microsoft.Extensions.Identity.Stores version)
102+
103+
## No Breaking Changes
104+
105+
This investigation confirmed existing functionality works correctly. No changes to the Pomelo provider implementation were needed or made.

0 commit comments

Comments
 (0)