Fixes for broken tests/warnings

Author: antisvin

LibSource/Oscillator.h

@@ -68,7 +68,7 @@ class Oscillator : public SignalGenerator {
 template<class T, class BaseOscillator=Oscillator, typename Sample=float>
 class OscillatorTemplate : public BaseOscillator {
 protected:
-  float mul;
+  float mul = 1;  // Prevent having NaN as default getFrequency result
   float phase = 0;
   float incr = 0;
 public:

TestPatches/QuadratureSineOscillatorTestPatch.hpp

@@ -45,13 +45,15 @@ class QuadratureSineOscillatorTestPatch : public TestPatch {
       AudioBuffer* s2 = AudioBuffer::create(2, 1000);
       ComplexFloatArray cmp = ComplexFloatArray::create(1000);
       osc1->generate(cmp);
-      cmp.copyTo(s1->getSamples(0), s2->getSamples(1));
+      cmp.copyTo(s1->getSamples(0), s1->getSamples(1));
       for(size_t i=0; i<1000; ++i) {
         ComplexFloat sample = osc2->generate();
         s2->getSamples(0)[i] = sample.re;
         s2->getSamples(1)[i] = sample.im;
       }
       for(size_t i=0; i<1000; ++i) {
+        CHECK_CLOSE(cmp[i].re, s2->getSamples(0)[i], 0.00002);
+        CHECK_CLOSE(cmp[i].im, s2->getSamples(1)[i], 0.00002);
         CHECK_CLOSE(s1->getSamples(0)[i], s2->getSamples(0)[i], 0.00002);
         CHECK_CLOSE(s1->getSamples(1)[i], s2->getSamples(1)[i], 0.00002);
       }
@@ -65,10 +67,10 @@ class QuadratureSineOscillatorTestPatch : public TestPatch {
         CHECK_CLOSE(cmp[i].re, s2->getSamples(0)[i], 0.00002);
         CHECK_CLOSE(cmp[i].im, s2->getSamples(1)[i], 0.00002);
       }
-      AudioBuffer::destroy(s1);      
-      AudioBuffer::destroy(s2);      
-      QuadratureSineOscillator::destroy(osc1);      
-      QuadratureSineOscillator::destroy(osc2);      
+      AudioBuffer::destroy(s1);
+      AudioBuffer::destroy(s2);
+      QuadratureSineOscillator::destroy(osc1);
+      QuadratureSineOscillator::destroy(osc2);
     }
 }
 };

TestPatches/SineOscillatorTestPatch.hpp

@@ -45,14 +45,14 @@ class SineOscillatorTestPatch : public TestPatch {
       FloatArray s2 = FloatArray::create(1000);
       osc1->generate(s1);
       for(size_t i=0; i<1000; ++i)
-	s2[i] = osc2->generate();
+        s2[i] = osc2->generate();
       for(size_t i=0; i<1000; ++i)
-	CHECK_CLOSE(s1[i], s2[i], 0.00002);
+        CHECK_CLOSE(s1[i], s2[i], 0.00002);
       osc1->generate(s1);
       for(size_t i=0; i<1000; ++i)
-	s2[i] = osc2->generate();
+        s2[i] = osc2->generate();
       for(size_t i=0; i<1000; ++i)
-	CHECK_CLOSE(s1[i], s2[i], 0.00002);
+        CHECK_CLOSE(s1[i], s2[i], 0.00002);
       FloatArray::destroy(s1);      
       FloatArray::destroy(s2);      
       SineOscillator::destroy(osc1);      

TestPatches/fileio.h

@@ -41,7 +41,7 @@ extern "C"{
         errx(1, "Data buffer not specified");
     if ((fd = creat(file_name, 0666)) < 1)
         errx(1, "Error creating file");
-    if (write(fd, data, size) < size)
+    if (write(fd, data, size) < ssize_t(size))
         errx(1, "Error writing samples");
     close(fd);
     return size;