Skip to content

Commit 05d36a5

Browse files
Dan Carpentergregkh
authored andcommitted
misc: cb710: Fix a NULL vs IS_ERR() check in probe()
The pcim_iomap_region() function never returns NULL, it returns error pointers. Update the checking to match. Fixes: b91c135 ("misc: cb710: Replace deprecated PCI functions") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Acked-by: Arnd Bergmann <arnd@arndb.de> Link: https://patch.msgid.link/aQITFDPyuzjNN4GN@stanley.mountain Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 4863cb2 commit 05d36a5

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/misc/cb710/core.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,8 +226,8 @@ static int cb710_probe(struct pci_dev *pdev,
226226
spin_lock_init(&chip->irq_lock);
227227
chip->pdev = pdev;
228228
chip->iobase = pcim_iomap_region(pdev, 0, KBUILD_MODNAME);
229-
if (!chip->iobase)
230-
return -ENOMEM;
229+
if (IS_ERR(chip->iobase))
230+
return PTR_ERR(chip->iobase);
231231

232232
pci_set_drvdata(pdev, chip);
233233

0 commit comments

Comments
 (0)