Skip to content

Commit 062191a

Browse files
acelanwesteri
authored andcommitted
thunderbolt: Log path activation failures without WARN backtraces
tb_path_activate() currently logs failures with tb_WARN(), which triggers a stack trace. Transient conditions such as lane bonding or Type-C link hiccups can fail path activation briefly, and the resulting backtraces are noisy without aiding diagnosis. Switch to tb_warn() for all path activation failures. The error code is already returned to callers, and the warning still shows the message without the backtrace. Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
1 parent 0c90fd3 commit 062191a

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/thunderbolt/path.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -586,7 +586,7 @@ int tb_path_activate(struct tb_path *path)
586586
tb_dbg(path->tb, "%s path activation complete\n", path->name);
587587
return 0;
588588
err:
589-
tb_WARN(path->tb, "%s path activation failed\n", path->name);
589+
tb_warn(path->tb, "%s path activation failed: %d\n", path->name, res);
590590
return res;
591591
}
592592

0 commit comments

Comments
 (0)