Skip to content

Commit 066b8f3

Browse files
qianfengrongmartinkpetersen
authored andcommitted
scsi: qla2xxx: edif: Fix incorrect sign of error code
Change the error code EAGAIN to -EAGAIN in qla24xx_sadb_update() and qla_edif_process_els() to align with qla2x00_start_sp() returning negative error codes or QLA_SUCCESS, preventing logical errors. Fixes: 0b3f314 ("scsi: qla2xxx: edif: Add retry for ELS passthrough") Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com> Message-ID: <20250905075446.381139-2-rongqianfeng@vivo.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 8f5ae30 commit 066b8f3

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/scsi/qla2xxx/qla_edif.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1798,7 +1798,7 @@ qla24xx_sadb_update(struct bsg_job *bsg_job)
17981798
switch (rval) {
17991799
case QLA_SUCCESS:
18001800
break;
1801-
case EAGAIN:
1801+
case -EAGAIN:
18021802
msleep(EDIF_MSLEEP_INTERVAL);
18031803
cnt++;
18041804
if (cnt < EDIF_RETRY_COUNT)
@@ -3649,7 +3649,7 @@ int qla_edif_process_els(scsi_qla_host_t *vha, struct bsg_job *bsg_job)
36493649
p->e.extra_rx_xchg_address, p->e.extra_control_flags,
36503650
sp->handle, sp->remap.req.len, bsg_job);
36513651
break;
3652-
case EAGAIN:
3652+
case -EAGAIN:
36533653
msleep(EDIF_MSLEEP_INTERVAL);
36543654
cnt++;
36553655
if (cnt < EDIF_RETRY_COUNT)

0 commit comments

Comments
 (0)