rtc: stmp3xxx: Add failure handling for stmp3xxx_wdt_register()

Lin Yujun · alexandrebelloni · commit 0759011157b0 · 2022-10-13T00:03:11.000+02:00
Use platform_device_put() to free platform device before print error message when platform_device_add() fails to run. Fixes: 1a71fb8 ("rtc: stmp3xxx: add wdt-accessor function") Signed-off-by: Lin Yujun <linyujun809@huawei.com> Reviewed-by: Wolfram Sang <wsa@kernel.org> Link: https://lore.kernel.org/r/20220915065253.43668-1-linyujun809@huawei.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
diff --git a/drivers/rtc/rtc-stmp3xxx.c b/drivers/rtc/rtc-stmp3xxx.c
@@ -107,6 +107,8 @@ static void stmp3xxx_wdt_register(struct platform_device *rtc_pdev)
 		wdt_pdev->dev.parent = &rtc_pdev->dev;
 		wdt_pdev->dev.platform_data = &wdt_pdata;
 		rc = platform_device_add(wdt_pdev);
+		if (rc)
+			platform_device_put(wdt_pdev);
 	}
 
 	if (rc)

Original file line number	Diff line number	Diff line change
`@@ -107,6 +107,8 @@ static void stmp3xxx_wdt_register(struct platform_device *rtc_pdev)`
`107`	`107`	`wdt_pdev->dev.parent = &rtc_pdev->dev;`
`108`	`108`	`wdt_pdev->dev.platform_data = &wdt_pdata;`
`109`	`109`	`rc = platform_device_add(wdt_pdev);`
	`110`	`+ if (rc)`
	`111`	`+ platform_device_put(wdt_pdev);`
`110`	`112`	`}`
`111`	`113`
`112`	`114`	`if (rc)`