selftests/landlock: Properly close a file descriptor

gnoack · l0kod · commit 15e8d739fda1 · 2026-01-09T11:52:47.000+01:00
Add a missing close(srv_fd) call, and use EXPECT_EQ() to check the result. Signed-off-by: Günther Noack <gnoack3000@gmail.com> Fixes: f83d51a ("selftests/landlock: Check IOCTL restrictions for named UNIX domain sockets") Link: https://lore.kernel.org/r/20260101134102.25938-2-gnoack3000@gmail.com [mic: Use EXPECT_EQ() and update commit message] Signed-off-by: Mickaël Salaün <mic@digikod.net>
diff --git a/tools/testing/selftests/landlock/fs_test.c b/tools/testing/selftests/landlock/fs_test.c
@@ -4399,7 +4399,8 @@ TEST_F_FORK(layout1, named_unix_domain_socket_ioctl)
 	/* FIONREAD and other IOCTLs should not be forbidden. */
 	EXPECT_EQ(0, test_fionread_ioctl(cli_fd));
 
-	ASSERT_EQ(0, close(cli_fd));
+	EXPECT_EQ(0, close(cli_fd));
+	EXPECT_EQ(0, close(srv_fd));
 }
 
 /* clang-format off */

Original file line number	Diff line number	Diff line change
`@@ -4399,7 +4399,8 @@ TEST_F_FORK(layout1, named_unix_domain_socket_ioctl)`
`4399`	`4399`	`/* FIONREAD and other IOCTLs should not be forbidden. */`
`4400`	`4400`	`EXPECT_EQ(0, test_fionread_ioctl(cli_fd));`
`4401`	`4401`
`4402`		`- ASSERT_EQ(0, close(cli_fd));`
	`4402`	`+ EXPECT_EQ(0, close(cli_fd));`
	`4403`	`+ EXPECT_EQ(0, close(srv_fd));`
`4403`	`4404`	`}`
`4404`	`4405`
`4405`	`4406`	`/* clang-format off */`