Skip to content

Commit 174974d

Browse files
committed
drm/msm/rd: Fix FIFO-full deadlock
If the previous thing cat'ing $debugfs/rd left the FIFO full, then subsequent open could deadlock in rd_write() (because open is blocked, not giving a chance for read() to consume any data in the FIFO). Also it is generally a good idea to clear out old data from the FIFO. Signed-off-by: Rob Clark <robdclark@chromium.org> Patchwork: https://patchwork.freedesktop.org/patch/496706/ Link: https://lore.kernel.org/r/20220807160901.2353471-2-robdclark@gmail.com
1 parent 02b9f26 commit 174974d

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

drivers/gpu/drm/msm/msm_rd.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,9 @@ static int rd_open(struct inode *inode, struct file *file)
196196
file->private_data = rd;
197197
rd->open = true;
198198

199+
/* Reset fifo to clear any previously unread data: */
200+
rd->fifo.head = rd->fifo.tail = 0;
201+
199202
/* the parsing tools need to know gpu-id to know which
200203
* register database to load.
201204
*

0 commit comments

Comments
 (0)