drm/i915/display: log fail from intel_sdvo_enable_hotplug

juhapekka · mkahola · commit 1de89eca2004 · 2025-09-05T15:24:45.000+03:00
Report in log if intel_sdvo_enable_hotplug failed Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com> Signed-off-by: Mika Kahola <mika.kahola@intel.com> Link: https://lore.kernel.org/r/20250905104626.1274147-2-juhapekka.heikkila@gmail.com
diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
@@ -2052,8 +2052,10 @@ static void intel_sdvo_enable_hotplug(struct intel_encoder *encoder)
 {
 	struct intel_sdvo *intel_sdvo = to_sdvo(encoder);
 
-	intel_sdvo_write_cmd(intel_sdvo, SDVO_CMD_SET_ACTIVE_HOT_PLUG,
-			     &intel_sdvo->hotplug_active, 2);
+	if (!intel_sdvo_write_cmd(intel_sdvo, SDVO_CMD_SET_ACTIVE_HOT_PLUG,
+				  &intel_sdvo->hotplug_active, 2))
+		drm_warn(intel_sdvo->base.base.dev,
+			 "Failed to enable hotplug on SDVO encoder\n");
 }
 
 static enum intel_hotplug_state

Original file line number	Diff line number	Diff line change
`@@ -2052,8 +2052,10 @@ static void intel_sdvo_enable_hotplug(struct intel_encoder *encoder)`
`2052`	`2052`	`{`
`2053`	`2053`	`struct intel_sdvo *intel_sdvo = to_sdvo(encoder);`
`2054`	`2054`
`2055`		`- intel_sdvo_write_cmd(intel_sdvo, SDVO_CMD_SET_ACTIVE_HOT_PLUG,`
`2056`		`- &intel_sdvo->hotplug_active, 2);`
	`2055`	`+ if (!intel_sdvo_write_cmd(intel_sdvo, SDVO_CMD_SET_ACTIVE_HOT_PLUG,`
	`2056`	`+ &intel_sdvo->hotplug_active, 2))`
	`2057`	`+ drm_warn(intel_sdvo->base.base.dev,`
	`2058`	`+ "Failed to enable hotplug on SDVO encoder\n");`
`2057`	`2059`	`}`
`2058`	`2060`
`2059`	`2061`	`static enum intel_hotplug_state`