Skip to content

Commit 3d35fa1

Browse files
committed
Merge tag 'linux_kselftest-fixes-6.19-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
Pull kselftest fixes from Shuah Khan: - Fix for build failures in tests that use an empty FIXTURE() seen in Android's build environment, which uses -D_FORTIFY_SOURCE=3, a build failure occurs in tests that use an empty FIXTURE() - Fix func_traceonoff_triggers.tc sometimes failures on Kunpeng-920 board resulting from including transient trace file name in checksum compare - Fix to remove available_events requirement from toplevel-enable for instance as it isn't a valid requirement for this test * tag 'linux_kselftest-fixes-6.19-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest: kselftest/harness: Use helper to avoid zero-size memset warning selftests/ftrace: Test toplevel-enable for instance selftests/ftrace: traceonoff_triggers: strip off names
2 parents bea82c8 + 19b8a76 commit 3d35fa1

3 files changed

Lines changed: 12 additions & 4 deletions

File tree

tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
#!/bin/sh
22
# SPDX-License-Identifier: GPL-2.0
33
# description: event tracing - enable/disable with top level files
4-
# requires: available_events set_event events/enable
4+
# requires: set_event events/enable
5+
# flags: instance
56

67
do_reset() {
78
echo > set_event

tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,10 @@ if [ $on != "0" ]; then
9090
fail "Tracing is not off"
9191
fi
9292

93-
csum1=`md5sum trace`
93+
# Cannot rely on names being around as they are only cached, strip them
94+
csum1=`cat trace | sed -e 's/^ *[^ ]*\(-[0-9][0-9]*\)/\1/' | md5sum`
9495
sleep $SLEEP_TIME
95-
csum2=`md5sum trace`
96+
csum2=`cat trace | sed -e 's/^ *[^ ]*\(-[0-9][0-9]*\)/\1/' | md5sum`
9697

9798
if [ "$csum1" != "$csum2" ]; then
9899
fail "Tracing file is still changing"

tools/testing/selftests/kselftest_harness.h

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,12 @@
7070

7171
#include "kselftest.h"
7272

73+
static inline void __kselftest_memset_safe(void *s, int c, size_t n)
74+
{
75+
if (n > 0)
76+
memset(s, c, n);
77+
}
78+
7379
#define TEST_TIMEOUT_DEFAULT 30
7480

7581
/* Utilities exposed to the test definitions */
@@ -416,7 +422,7 @@
416422
self = mmap(NULL, sizeof(*self), PROT_READ | PROT_WRITE, \
417423
MAP_SHARED | MAP_ANONYMOUS, -1, 0); \
418424
} else { \
419-
memset(&self_private, 0, sizeof(self_private)); \
425+
__kselftest_memset_safe(&self_private, 0, sizeof(self_private)); \
420426
self = &self_private; \
421427
} \
422428
} \

0 commit comments

Comments
 (0)