Skip to content

Commit 3f74700

Browse files
Yuuoniyvinodkoul
authored andcommitted
dmaengine: qcom: gpi: Fix memory leak in gpi_peripheral_config()
Fix a memory leak in gpi_peripheral_config() where the original memory pointed to by gchan->config could be lost if krealloc() fails. The issue occurs when: 1. gchan->config points to previously allocated memory 2. krealloc() fails and returns NULL 3. The function directly assigns NULL to gchan->config, losing the reference to the original memory 4. The original memory becomes unreachable and cannot be freed Fix this by using a temporary variable to hold the krealloc() result and only updating gchan->config when the allocation succeeds. Found via static analysis and code review. Fixes: 5d0c353 ("dmaengine: qcom: Add GPI dma driver") Cc: stable@vger.kernel.org Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Reviewed-by: Bjorn Andersson <andersson@kernel.org> Link: https://patch.msgid.link/20251029123421.91973-1-linmq006@gmail.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 747213b commit 3f74700

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

drivers/dma/qcom/gpi.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1605,14 +1605,16 @@ static int
16051605
gpi_peripheral_config(struct dma_chan *chan, struct dma_slave_config *config)
16061606
{
16071607
struct gchan *gchan = to_gchan(chan);
1608+
void *new_config;
16081609

16091610
if (!config->peripheral_config)
16101611
return -EINVAL;
16111612

1612-
gchan->config = krealloc(gchan->config, config->peripheral_size, GFP_NOWAIT);
1613-
if (!gchan->config)
1613+
new_config = krealloc(gchan->config, config->peripheral_size, GFP_NOWAIT);
1614+
if (!new_config)
16141615
return -ENOMEM;
16151616

1617+
gchan->config = new_config;
16161618
memcpy(gchan->config, config->peripheral_config, config->peripheral_size);
16171619

16181620
return 0;

0 commit comments

Comments
 (0)