Skip to content

Commit 45c9faf

Browse files
mjguzikbrauner
authored andcommitted
vfs: make evict() use smp_mb__after_spinlock instead of smp_mb
It literally directly follows a spin_lock() call. This whacks an explicit barrier on x86-64. Signed-off-by: Mateusz Guzik <mjguzik@gmail.com> Link: https://lore.kernel.org/r/20241113155103.4194099-1-mjguzik@gmail.com Reviewed-by: Jan Kara <jack@suse.cz> Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent 2f4d450 commit 45c9faf

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/inode.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -746,7 +746,7 @@ static void evict(struct inode *inode)
746746
* ___wait_var_event() either sees the bit cleared or
747747
* waitqueue_active() check in wake_up_var() sees the waiter.
748748
*/
749-
smp_mb();
749+
smp_mb__after_spinlock();
750750
inode_wake_up_bit(inode, __I_NEW);
751751
BUG_ON(inode->i_state != (I_FREEING | I_CLEAR));
752752
spin_unlock(&inode->i_lock);

0 commit comments

Comments
 (0)