powerpc-km82xx.c: replace of_node_put() with __free

David Hunter · mpe · commit 4aa5cc1e0012 · 2024-11-15T10:35:58.000+11:00
The use of the __free macro allows the cleanup to be based on scope instead of on another function called later. This makes the cleanup automatic and less susceptible to errors later. Signed-off-by: David Hunter <david.hunter.linux@gmail.com> [mpe: Fix over-long line & change log wording] Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://patch.msgid.link/20240709143553.117053-1-david.hunter.linux@gmail.com
diff --git a/arch/powerpc/platforms/82xx/km82xx.c b/arch/powerpc/platforms/82xx/km82xx.c
@@ -27,15 +27,15 @@
 
 static void __init km82xx_pic_init(void)
 {
-	struct device_node *np = of_find_compatible_node(NULL, NULL,
-							"fsl,pq2-pic");
+	struct device_node *np __free(device_node);
+	np = of_find_compatible_node(NULL, NULL, "fsl,pq2-pic");
+
 	if (!np) {
 		pr_err("PIC init: can not find cpm-pic node\n");
 		return;
 	}
 
 	cpm2_pic_init(np);
-	of_node_put(np);
 }
 
 struct cpm_pin {

Original file line number	Diff line number	Diff line change
`@@ -27,15 +27,15 @@`
`27`	`27`
`28`	`28`	`static void __init km82xx_pic_init(void)`
`29`	`29`	`{`
`30`		`- struct device_node *np = of_find_compatible_node(NULL, NULL,`
`31`		`- "fsl,pq2-pic");`
	`30`	`+ struct device_node *np __free(device_node);`
	`31`	`+ np = of_find_compatible_node(NULL, NULL, "fsl,pq2-pic");`
	`32`	`+`
`32`	`33`	`if (!np) {`
`33`	`34`	`pr_err("PIC init: can not find cpm-pic node\n");`
`34`	`35`	`return;`
`35`	`36`	`}`
`36`	`37`
`37`	`38`	`cpm2_pic_init(np);`
`38`		`- of_node_put(np);`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`struct cpm_pin {`