Skip to content

Commit 5b9481a

Browse files
gastmaieralexandrebelloni
authored andcommitted
i3c: master: Remove i3c_device_free_ibi from i3c_device_remove
i3c_device_disable_ibi should be called before i3c_device_free_ibi, however, a driver using devm actions cannot yield the call before the bus_type.remove(), requiring to use a .remove method that is usually discouraged for drivers that uses resources already manage. Since the only consumer mctp-i3c.c of this method calls both i3c_device_disable_ibi then i3c_device_free_ibi, remove the call from the i3c_device_remove (bus_type.remove()). Signed-off-by: Jorge Marques <jorge.marques@analog.com> Link: https://patch.msgid.link/20251112-ibi-unsafe-v1-1-d8454db22613@analog.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent a54b1ae commit 5b9481a

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

drivers/i3c/master.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -334,8 +334,6 @@ static void i3c_device_remove(struct device *dev)
334334

335335
if (driver->remove)
336336
driver->remove(i3cdev);
337-
338-
i3c_device_free_ibi(i3cdev);
339337
}
340338

341339
const struct bus_type i3c_bus_type = {

0 commit comments

Comments
 (0)