mmc: renesas_sdhi: disable clocks if registering regulator failed

Wolfram Sang · Ulf Hansson · commit 77183db6b8db · 2025-04-07T17:58:41.000+02:00
Because the clocks were just enabled, bail out to the proper target if there are problems with the regulator. Fixes: fae80a9 ("mmc: renesas_sdhi: Add support for RZ/G3E SoC") Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> Tested-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Link: https://lore.kernel.org/r/20250330221732.56072-2-wsa+renesas@sang-engineering.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
@@ -1179,7 +1179,7 @@ int renesas_sdhi_probe(struct platform_device *pdev,
 		if (IS_ERR(rdev)) {
 			dev_err(dev, "regulator register failed err=%ld", PTR_ERR(rdev));
 			ret = PTR_ERR(rdev);
-			goto efree;
+			goto edisclk;
 		}
 		priv->rdev = rdev;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1179,7 +1179,7 @@ int renesas_sdhi_probe(struct platform_device *pdev,`
`1179`	`1179`	`if (IS_ERR(rdev)) {`
`1180`	`1180`	`dev_err(dev, "regulator register failed err=%ld", PTR_ERR(rdev));`
`1181`	`1181`	`ret = PTR_ERR(rdev);`
`1182`		`- goto efree;`
	`1182`	`+ goto edisclk;`
`1183`	`1183`	`}`
`1184`	`1184`	`priv->rdev = rdev;`
`1185`	`1185`	`}`