Skip to content

Commit 8bac40b

Browse files
plbossartbroonie
authored andcommitted
ASoC: SOF: Intel: hda-ctrl: re-add sleep after entering and exiting reset
This reverts commit a09d82c ("ASoC: SOF: Intel: hda-ctrl: remove useless sleep") It was a mistake to remove those delays, in light of comments in the HDaudio spec captured in snd_hdac_bus_reset_link() that the codec needs time for its initialization and PLL lock. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com> Reviewed-by: Rander Wang <rander.wang@intel.com> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> Link: https://lore.kernel.org/r/20230307095412.3416-1-peter.ujfalusi@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 52a5577 commit 8bac40b

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

sound/soc/sof/intel/hda-ctrl.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,12 +196,15 @@ int hda_dsp_ctrl_init_chip(struct snd_sof_dev *sdev)
196196
goto err;
197197
}
198198

199+
usleep_range(500, 1000);
200+
199201
/* exit HDA controller reset */
200202
ret = hda_dsp_ctrl_link_reset(sdev, false);
201203
if (ret < 0) {
202204
dev_err(sdev->dev, "error: failed to exit HDA controller reset\n");
203205
goto err;
204206
}
207+
usleep_range(1000, 1200);
205208

206209
hda_codec_detect_mask(sdev);
207210

0 commit comments

Comments
 (0)