i3c: master: Free the old_dyn_addr when reattach.

billy-tsai · alexandrebelloni · commit d4fa7d772adc · 2022-10-12T23:45:29.000+02:00
This patch is used to free the old_dyn_addr when the caller want to reattach the device to the different dynamic address. If the old_dyn_addr is 0 the function will treat it as no old_dyn_addr is reserved on the bus. Without the patch, when the driver reattach the i3c device after setnewda the old_dyn_addr will be permanently occupied. Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> Link: https://lore.kernel.org/r/20220926105145.8145-1-billy_tsai@aspeedtech.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
@@ -1379,6 +1379,9 @@ static int i3c_master_reattach_i3c_dev(struct i3c_dev_desc *dev,
 		i3c_bus_set_addr_slot_status(&master->bus,
 					     dev->info.dyn_addr,
 					     I3C_ADDR_SLOT_I3C_DEV);
+		if (old_dyn_addr)
+			i3c_bus_set_addr_slot_status(&master->bus, old_dyn_addr,
+						     I3C_ADDR_SLOT_FREE);
 	}
 
 	if (master->ops->reattach_i3c_dev) {

Original file line number	Diff line number	Diff line change
`@@ -1379,6 +1379,9 @@ static int i3c_master_reattach_i3c_dev(struct i3c_dev_desc *dev,`
`1379`	`1379`	`i3c_bus_set_addr_slot_status(&master->bus,`
`1380`	`1380`	`dev->info.dyn_addr,`
`1381`	`1381`	`I3C_ADDR_SLOT_I3C_DEV);`
	`1382`	`+ if (old_dyn_addr)`
	`1383`	`+ i3c_bus_set_addr_slot_status(&master->bus, old_dyn_addr,`
	`1384`	`+ I3C_ADDR_SLOT_FREE);`
`1382`	`1385`	`}`
`1383`	`1386`
`1384`	`1387`	`if (master->ops->reattach_i3c_dev) {`