Skip to content

Commit e91bbe0

Browse files
DispatchCodegregkh
authored andcommitted
USB: add WQ_PERCPU to alloc_workqueue users
Currently if a user enqueues a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistency cannot be addressed without refactoring the API. alloc_workqueue() treats all queues as per-CPU by default, while unbound workqueues must opt-in via WQ_UNBOUND. This default is suboptimal: most workloads benefit from unbound queues, allowing the scheduler to place worker threads where they’re needed and reducing noise when CPUs are isolated. This continues the effort to refactor workqueue APIs, which began with the introduction of new workqueues and a new alloc_workqueue flag in: commit 128ea9f ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea ("workqueue: Add new WQ_PERCPU flag") This change adds a new WQ_PERCPU flag to explicitly request alloc_workqueue() to be per-cpu when WQ_UNBOUND has not been specified. With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND), any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND must now use WQ_PERCPU. Once migration is complete, WQ_UNBOUND can be removed and unbound will become the implicit default. Suggested-by: Tejun Heo <tj@kernel.org> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com> Link: https://patch.msgid.link/20251107153737.301413-2-marco.crivellari@suse.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent b43889f commit e91bbe0

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

drivers/usb/core/hub.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6078,7 +6078,7 @@ int usb_hub_init(void)
60786078
* device was gone before the EHCI controller had handed its port
60796079
* over to the companion full-speed controller.
60806080
*/
6081-
hub_wq = alloc_workqueue("usb_hub_wq", WQ_FREEZABLE, 0);
6081+
hub_wq = alloc_workqueue("usb_hub_wq", WQ_FREEZABLE | WQ_PERCPU, 0);
60826082
if (hub_wq)
60836083
return 0;
60846084

drivers/usb/gadget/function/f_hid.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1272,8 +1272,7 @@ static int hidg_bind(struct usb_configuration *c, struct usb_function *f)
12721272

12731273
INIT_WORK(&hidg->work, get_report_workqueue_handler);
12741274
hidg->workqueue = alloc_workqueue("report_work",
1275-
WQ_FREEZABLE |
1276-
WQ_MEM_RECLAIM,
1275+
WQ_FREEZABLE | WQ_MEM_RECLAIM | WQ_PERCPU,
12771276
1);
12781277

12791278
if (!hidg->workqueue) {

0 commit comments

Comments
 (0)