Skip to content

Commit eb43534

Browse files
ConchuODclaudiubeznea
authored andcommitted
dt-bindings: clk: microchip: mpfs: remove first reg region
The first reg region in this binding is not exclusively for clocks, as evidenced by the dual role of this device as a reset controller at present. The first region is however better described by a simple-mfd syscon, but this would have require a significant re-write of the devicetree for the platform, so the easy way out was chosen when reset support was first introduced. The region doesn't just contain clock and reset registers, it also contains pinctrl and interrupt controller functionality, so drop the region from the clock binding so that it can be described instead by a simple-mfd syscon rather than propagate this incorrect description of the hardware to the new pic64gx SoC. Acked-by: Rob Herring (Arm) <robh@kernel.org> Signed-off-by: Conor Dooley <conor.dooley@microchip.com> Link: https://lore.kernel.org/r/20251029-unwatched-family-e47cb29ea815@spud Signed-off-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
1 parent 3a86608 commit eb43534

1 file changed

Lines changed: 22 additions & 14 deletions

File tree

Documentation/devicetree/bindings/clock/microchip,mpfs-clkcfg.yaml

Lines changed: 22 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,23 @@ properties:
2222
const: microchip,mpfs-clkcfg
2323

2424
reg:
25-
items:
26-
- description: |
27-
clock config registers:
28-
These registers contain enable, reset & divider tables for the, cpu,
29-
axi, ahb and rtc/mtimer reference clocks as well as enable and reset
30-
for the peripheral clocks.
31-
- description: |
32-
mss pll dri registers:
33-
Block of registers responsible for dynamic reconfiguration of the mss
34-
pll
25+
oneOf:
26+
- items:
27+
- description: |
28+
clock config registers:
29+
These registers contain enable, reset & divider tables for the, cpu,
30+
axi, ahb and rtc/mtimer reference clocks as well as enable and reset
31+
for the peripheral clocks.
32+
- description: |
33+
mss pll dri registers:
34+
Block of registers responsible for dynamic reconfiguration of the mss
35+
pll
36+
deprecated: true
37+
- items:
38+
- description: |
39+
mss pll dri registers:
40+
Block of registers responsible for dynamic reconfiguration of the mss
41+
pll
3542
3643
clocks:
3744
maxItems: 1
@@ -69,11 +76,12 @@ examples:
6976
- |
7077
#include <dt-bindings/clock/microchip,mpfs-clock.h>
7178
soc {
72-
#address-cells = <2>;
73-
#size-cells = <2>;
74-
clkcfg: clock-controller@20002000 {
79+
#address-cells = <1>;
80+
#size-cells = <1>;
81+
82+
clkcfg: clock-controller@3E001000 {
7583
compatible = "microchip,mpfs-clkcfg";
76-
reg = <0x0 0x20002000 0x0 0x1000>, <0x0 0x3E001000 0x0 0x1000>;
84+
reg = <0x3E001000 0x1000>;
7785
clocks = <&ref>;
7886
#clock-cells = <1>;
7987
};

0 commit comments

Comments
 (0)