Skip to content

Commit ef90b10

Browse files
Darksonnojeda
authored andcommitted
tyr: remove impl Send/Sync for TyrData
Now that clk implements Send and Sync, we no longer need to manually implement these traits for TyrData. Thus remove the implementations. The comment also mentions the regulator. However, the regulator had the traits added in commit 9a200cb ("rust: regulator: implement Send and Sync for Regulator<T>"), which is already in mainline. Reviewed-by: Danilo Krummrich <dakr@kernel.org> Reviewed-by: Boqun Feng <boqun.feng@gmail.com> Reviewed-by: Gary Guo <gary@garyguo.net> Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com> Signed-off-by: Alice Ryhl <aliceryhl@google.com> Link: https://patch.msgid.link/20260223-clk-send-sync-v5-2-181bf2f35652@google.com Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
1 parent 0c0695a commit ef90b10

1 file changed

Lines changed: 0 additions & 12 deletions

File tree

drivers/gpu/drm/tyr/driver.rs

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -53,18 +53,6 @@ pub(crate) struct TyrData {
5353
pub(crate) gpu_info: GpuInfo,
5454
}
5555

56-
// Both `Clk` and `Regulator` do not implement `Send` or `Sync`, but they
57-
// should. There are patches on the mailing list to address this, but they have
58-
// not landed yet.
59-
//
60-
// For now, add this workaround so that this patch compiles with the promise
61-
// that it will be removed in a future patch.
62-
//
63-
// SAFETY: This will be removed in a future patch.
64-
unsafe impl Send for TyrData {}
65-
// SAFETY: This will be removed in a future patch.
66-
unsafe impl Sync for TyrData {}
67-
6856
fn issue_soft_reset(dev: &Device<Bound>, iomem: &Devres<IoMem>) -> Result {
6957
regs::GPU_CMD.write(dev, iomem, regs::GPU_CMD_SOFT_RESET)?;
7058

0 commit comments

Comments
 (0)