Skip to content

Commit 2e5a4f7

Browse files
committed
Refactor NestedLock -> NestLock.
1 parent f1fa455 commit 2e5a4f7

7 files changed

Lines changed: 18 additions & 18 deletions

File tree

include/opdi/backend/backendInterface.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ namespace opdi {
3939
virtual void finalize() = 0;
4040

4141
virtual std::size_t getLockIdentifier(omp_lock_t* lock) = 0;
42-
virtual std::size_t getNestedLockIdentifier(omp_nest_lock_t* lock) = 0;
42+
virtual std::size_t getNestLockIdentifier(omp_nest_lock_t* lock) = 0;
4343

4444
virtual void* getParallelData() = 0;
4545
virtual void* getTaskData() = 0;

include/opdi/backend/macro/macroBackend.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,8 @@ namespace opdi {
6969

7070
void opdi_destroy_nest_lock(omp_nest_lock_t* lock) {
7171
omp_destroy_nest_lock(lock);
72-
opdi::logic->onMutexDestroyed(LogicInterface::MutexKind::NestedLock,
73-
opdi::backend->getNestedLockIdentifier(lock));
72+
opdi::logic->onMutexDestroyed(LogicInterface::MutexKind::NestLock,
73+
opdi::backend->getNestLockIdentifier(lock));
7474
}
7575

7676
void opdi_set_lock(omp_lock_t* lock) {
@@ -82,8 +82,8 @@ namespace opdi {
8282
omp_set_nest_lock(lock);
8383
int lockCount = omp_test_nest_lock(lock); // user triggered locks plus lock caused by test
8484
if (lockCount == 2) {
85-
opdi::logic->onMutexAcquired(LogicInterface::MutexKind::NestedLock,
86-
opdi::backend->getNestedLockIdentifier(lock));
85+
opdi::logic->onMutexAcquired(LogicInterface::MutexKind::NestLock,
86+
opdi::backend->getNestLockIdentifier(lock));
8787
}
8888
omp_unset_nest_lock(lock); // revert lock caused by test
8989
}
@@ -96,8 +96,8 @@ namespace opdi {
9696
void opdi_unset_nest_lock(omp_nest_lock_t* lock) {
9797
int lockCount = omp_test_nest_lock(lock); // user triggered locks plus lock caused by test
9898
if (lockCount == 2) {
99-
opdi::logic->onMutexReleased(LogicInterface::MutexKind::NestedLock,
100-
opdi::backend->getNestedLockIdentifier(lock));
99+
opdi::logic->onMutexReleased(LogicInterface::MutexKind::NestLock,
100+
opdi::backend->getNestLockIdentifier(lock));
101101
}
102102
omp_unset_nest_lock(lock); // revert lock caused by test
103103
omp_unset_nest_lock(lock); // user triggered unlock
@@ -114,8 +114,8 @@ namespace opdi {
114114
int opdi_test_nest_lock(omp_nest_lock_t* lock) {
115115
int lockCount = omp_test_nest_lock(lock);
116116
if (lockCount == 1) {
117-
opdi::logic->onMutexAcquired(LogicInterface::MutexKind::NestedLock,
118-
opdi::backend->getNestedLockIdentifier(lock));
117+
opdi::logic->onMutexAcquired(LogicInterface::MutexKind::NestLock,
118+
opdi::backend->getNestLockIdentifier(lock));
119119
}
120120
return lockCount;
121121
}

include/opdi/backend/macro/mutexIdentifiers.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ namespace opdi {
7171
return reinterpret_cast<std::size_t>(lock);
7272
}
7373

74-
std::size_t getNestedLockIdentifier(omp_nest_lock_t* lock) {
74+
std::size_t getNestLockIdentifier(omp_nest_lock_t* lock) {
7575
return reinterpret_cast<std::size_t>(lock);
7676
}
7777
};

include/opdi/backend/ompt/mutexCallbacks.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ namespace opdi {
5858
break;
5959
case ompt_mutex_nest_lock:
6060
case ompt_mutex_test_nest_lock:
61-
logic->onMutexDestroyed(LogicInterface::MutexKind::NestedLock, waitId);
61+
logic->onMutexDestroyed(LogicInterface::MutexKind::NestLock, waitId);
6262
break;
6363
case ompt_mutex_critical:
6464
logic->onMutexDestroyed(LogicInterface::MutexKind::Critical, waitId);
@@ -86,7 +86,7 @@ namespace opdi {
8686
break;
8787
case ompt_mutex_nest_lock:
8888
case ompt_mutex_test_nest_lock:
89-
logic->onMutexAcquired(LogicInterface::MutexKind::NestedLock, waitId);
89+
logic->onMutexAcquired(LogicInterface::MutexKind::NestLock, waitId);
9090
break;
9191
case ompt_mutex_critical:
9292
logic->onMutexAcquired(LogicInterface::MutexKind::Critical, waitId);
@@ -114,7 +114,7 @@ namespace opdi {
114114
break;
115115
case ompt_mutex_nest_lock:
116116
case ompt_mutex_test_nest_lock:
117-
logic->onMutexReleased(LogicInterface::MutexKind::NestedLock, waitId);
117+
logic->onMutexReleased(LogicInterface::MutexKind::NestLock, waitId);
118118
break;
119119
case ompt_mutex_critical:
120120
logic->onMutexReleased(LogicInterface::MutexKind::Critical, waitId);

include/opdi/backend/ompt/omptBackend.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ namespace opdi {
151151
return (std::size_t) waitId;
152152
}
153153

154-
std::size_t getNestedLockIdentifier(omp_nest_lock_t* lock) {
154+
std::size_t getNestLockIdentifier(omp_nest_lock_t* lock) {
155155

156156
ompt_wait_id_t waitId;
157157
WaitIdExtractor::begin(&waitId);

include/opdi/logic/logicInterface.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ namespace opdi {
3434
public:
3535

3636
enum MutexKind : std::size_t {
37-
Critical = 0, Lock, NestedLock, Ordered, Reduction, Custom
37+
Critical = 0, Lock, NestLock, Ordered, Reduction, Custom
3838
};
3939

4040
static constexpr std::size_t nMutexKind = 6;

tests/tests/TestNestedLock.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@
2828
#include "testBase.hpp"
2929

3030
template<typename _Case>
31-
struct TestNestedLock : public TestBase<4, 1, 3, TestNestedLock<_Case>> {
31+
struct TestNestLock : public TestBase<4, 1, 3, TestNestLock<_Case>> {
3232
public:
3333
using Case = _Case;
34-
using Base = TestBase<4, 1, 3, TestNestedLock<Case>>;
34+
using Base = TestBase<4, 1, 3, TestNestLock<Case>>;
3535

3636
template<typename T>
3737
static void job(int i, std::array<T, Base::nIn> const& in, T& result1, T& result2,
@@ -105,7 +105,7 @@ struct TestNestedLock : public TestBase<4, 1, 3, TestNestedLock<_Case>> {
105105
int end = std::min(N, ((N - 1) / nThreads + 1) * (omp_get_thread_num() + 1));
106106

107107
for (int i = start; i < end; ++i) {
108-
TestNestedLock::job(i, in, out1, out2, &lock1, &lock2);
108+
TestNestLock::job(i, in, out1, out2, &lock1, &lock2);
109109
}
110110
}
111111
OPDI_END_PARALLEL

0 commit comments

Comments
 (0)