Additional warnings and errors.

Errors
- recordings during passive parallel regions
- reverse parallel region does not use requested number of threads
- actual number of threads exceeds maximum number of threads

Warnings
- parallel region for cleanup does not use requested number of threads

Merge branch 'feature/errorHandling' into develop

Author: jblueh

include/opdi/logic/omp/implicitTaskOmpLogic.cpp

@@ -61,6 +61,9 @@ void* opdi::ImplicitTaskOmpLogic::onImplicitTaskBegin(bool initialImplicitTask,
     // adjoint access mode.
     if (!initialImplicitTask) {
       if (index == 0) {
+        if (parallelData->maxThreads < actualParallelism) {
+          OPDI_ERROR("Actual number of threads exceeds maximum number of threads.");
+        }
         parallelData->actualThreads = actualParallelism;
       }
 
@@ -127,8 +130,8 @@ void opdi::ImplicitTaskOmpLogic::onImplicitTaskEnd(void* dataPtr) {
 
       if (!data->parallelData->activeParallelRegion) {
         if (tool->comparePosition(data->positions.front(), data->positions.back()) != 0) {
-          OPDI_WARNING("Something became active during a passive parallel region. This is not supported and will not ",
-                       "be differentiated correctly.");
+          OPDI_ERROR("Something became active during a passive parallel region. This is not supported and will not be",
+                     "differentiated correctly.");
         }
       }
       else {

include/opdi/logic/omp/parallelOmpLogic.cpp

@@ -51,6 +51,10 @@ void opdi::ParallelOmpLogic::reverseFunc(void* dataPtr) {
 
   #pragma omp parallel num_threads(data->actualThreads)
   {
+    if (data->actualThreads != omp_get_num_threads()) {
+      OPDI_ERROR("Parallel region in the reverse pass does not use the required number of threads.");
+    }
+
     int threadNum = omp_get_thread_num();
 
     ImplicitTaskOmpLogic::Data* taskData = reinterpret_cast<ImplicitTaskOmpLogic::Data*>(data->childTasks[threadNum]);
@@ -108,6 +112,10 @@ void opdi::ParallelOmpLogic::deleteFunc(void* dataPtr) {
   // this triggers possibly pending implicit task end events
   #pragma omp parallel num_threads(data->actualThreads)
   {
+    if (data->actualThreads != omp_get_num_threads()) {
+      OPDI_WARNING("Parallel region during cleanup does not use the required number of threads.");
+    }
+
     int threadNum = omp_get_thread_num();
 
     ImplicitTaskOmpLogic::Data* taskData = reinterpret_cast<ImplicitTaskOmpLogic::Data*>(data->childTasks[threadNum]);